Re: Review Request 119459: Added some Unittest for FileMonitor

2014-07-29 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119459/ --- (Updated July 29, 2014, 12:36 p.m.) Status -- This change has been m

Re: Review Request 119459: Added some Unittest for FileMonitor

2014-07-29 Thread Vishesh Handa
> On July 28, 2014, 4:38 p.m., Vishesh Handa wrote: > > Maybe we want to declare the FileMonitor in each test, but I don't have a > > strong opinion on it. I'm fine with the patch. Nice job! > > Felix Eisele wrote: > Thanks. I have no write access to git. Can I you please push for me? I >

Re: Review Request 119459: Added some Unittest for FileMonitor

2014-07-28 Thread Felix Eisele
> On Juli 28, 2014, 6:38 nachm., Vishesh Handa wrote: > > Maybe we want to declare the FileMonitor in each test, but I don't have a > > strong opinion on it. I'm fine with the patch. Nice job! Thanks. I have no write access to git. Can I you please push for me? I would to get a contributer acc

Re: Review Request 119459: Added some Unittest for FileMonitor

2014-07-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119459/#review63339 --- Ship it! Maybe we want to declare the FileMonitor in each tes

Re: Review Request 119459: Added some Unittest for FileMonitor

2014-07-26 Thread Marc Schmitzer
On Saturday 26 July 2014 11:58:32 Felix Eisele wrote: > > On Juli 25, 2014, 12:04 nachm., Vishesh Handa wrote: > > > src/file/autotest/filemonitortest.h, line 37 > > > > > line37>> > > > > Just out of curiosity, is ther

Re: Review Request 119459: Added some Unittest for FileMonitor

2014-07-26 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119459/ --- (Updated Juli 26, 2014, 1:58 nachm.) Review request for Baloo and Vishesh

Re: Review Request 119459: Added some Unittest for FileMonitor

2014-07-26 Thread Felix Eisele
> On Juli 25, 2014, 12:04 nachm., Vishesh Handa wrote: > > src/file/autotest/filemonitortest.h, line 37 > > > > > > Just out of curiosity, is there any advantage of making it a member > > variable instead of just

Re: Review Request 119459: Added some Unittest for FileMonitor

2014-07-25 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119459/#review63120 --- src/file/autotest/filemonitortest.h

Review Request 119459: Added some Unittest for FileMonitor

2014-07-25 Thread Felix Eisele
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119459/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti