Re: Review Request 119441: Akonadi-Indexer: Collection indexing

2015-02-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119441/#review75772 --- Upstreaming this is going to be hard since we're no longer mak

Re: Review Request 119441: Akonadi-Indexer: Collection indexing

2015-02-10 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119441/ --- (Updated Feb. 10, 2015, 9:06 a.m.) Status -- This change has been di

Re: Review Request 119441: Akonadi-Indexer: Collection indexing

2015-02-10 Thread Christian Mollekopf
> On Aug. 7, 2014, 4:57 p.m., Vishesh Handa wrote: > > I'm not sure I usee why this is required, but I'm sure you have a use case. > > Feel free to push it. It's required for a new calendar selection interface that allows you to select new calendars by searching through the locally available o

Re: Review Request 119441: Akonadi-Indexer: Collection indexing

2015-02-04 Thread Vishesh Handa
> On Aug. 7, 2014, 4:57 p.m., Vishesh Handa wrote: > > src/pim/agent/collectionindexer.cpp, line 89 > > > > > > Be careful with this. Indexing phrases nearly doubles the size of the > > index. Considering the amo

Re: Review Request 119441: Akonadi-Indexer: Collection indexing

2014-08-07 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119441/#review64001 --- Ship it! I'm not sure I usee why this is required, but I'm su

Re: Review Request 119441: Akonadi-Indexer: Collection indexing

2014-07-24 Thread Christian Mollekopf
> On July 24, 2014, 8:38 a.m., Dan Vrátil wrote: > > I know this is not a review for me, but I was curious :-) This review is for everyone how cares, and I always appreciate your input =) > On July 24, 2014, 8:38 a.m., Dan Vrátil wrote: > > src/pim/agent/collectionindexer.cpp, line 65 > >

Re: Review Request 119441: Akonadi-Indexer: Collection indexing

2014-07-24 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119441/#review63032 --- I know this is not a review for me, but I was curious :-) sr

Review Request 119441: Akonadi-Indexer: Collection indexing

2014-07-23 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119441/ --- Review request for Baloo. Repository: baloo Description --- Akonad