Re: Review Request 118466: Make QtTest optional

2014-06-02 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118466/ --- (Updated June 2, 2014, 3:46 p.m.) Status -- This change has been mar

Re: Review Request 118466: Make QtTest optional

2014-06-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118466/#review58990 --- This review has been submitted with commit 1f079ca96dd633fc4c

Re: Review Request 118466: Make QtTest optional

2014-06-02 Thread Michael Palimaka
> On June 2, 2014, 3:43 p.m., Vishesh Handa wrote: > > I still don't see the point, but alright, you must see some value :) Thanks, appreciate it! - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.rev

Re: Review Request 118466: Make QtTest optional

2014-06-02 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118466/#review58987 --- Ship it! I still don't see the point, but alright, you must s

Re: Review Request 118466: Make QtTest optional

2014-06-02 Thread Michael Palimaka
> On June 2, 2014, 1:02 p.m., Vishesh Handa wrote: > > Considering that QtTest is part of qtbase, does this really have much of an > > advantage? That's true, however some distributions split qtbase into its various parts. - Michael --

Re: Review Request 118466: Make QtTest optional

2014-06-02 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118466/#review58959 --- Considering that QtTest is part of qtbase, does this really ha

Review Request 118466: Make QtTest optional

2014-06-02 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118466/ --- Review request for Baloo. Repository: baloo Description --- While