Re: Review Request 114983: Misc changes to the file queue

2014-01-13 Thread Simeon Bird
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114983/ --- (Updated Jan. 13, 2014, 11:35 p.m.) Status -- This change has been m

Re: Review Request 114983: Misc changes to the file queue

2014-01-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114983/#review47354 --- This review has been submitted with commit c7067d567b60b5a586

Re: Review Request 114983: Misc changes to the file queue

2014-01-13 Thread Vishesh Handa
> On Jan. 12, 2014, 4:11 p.m., Vishesh Handa wrote: > > This is awesome. Ship it! > > If you want you can also get rid of the IndexCleaner completely. I think ti > > might be better to move it into the KCM, and only run it when the > > configuration changes. There isn't much point running it ea

Re: Review Request 114983: Misc changes to the file queue

2014-01-13 Thread Simeon Bird
> On Jan. 12, 2014, 4:11 p.m., Vishesh Handa wrote: > > This is awesome. Ship it! > > If you want you can also get rid of the IndexCleaner completely. I think ti > > might be better to move it into the KCM, and only run it when the > > configuration changes. There isn't much point running it ea

Re: Review Request 114983: Misc changes to the file queue

2014-01-13 Thread Vishesh Handa
> On Jan. 12, 2014, 4:11 p.m., Vishesh Handa wrote: > > src/file/indexscheduler.cpp, line 185 > > > > > > I'm a little bit concerned about this because one might decide that the > > BasicIQ should not check ever

Re: Review Request 114983: Misc changes to the file queue

2014-01-13 Thread Vishesh Handa
> On Jan. 12, 2014, 4:11 p.m., Vishesh Handa wrote: > > This is awesome. Ship it! > > If you want you can also get rid of the IndexCleaner completely. I think ti > > might be better to move it into the KCM, and only run it when the > > configuration changes. There isn't much point running it ea

Re: Review Request 114983: Misc changes to the file queue

2014-01-12 Thread Simeon Bird
> On Jan. 12, 2014, 4:11 p.m., Vishesh Handa wrote: > > This is awesome. Ship it! > > If you want you can also get rid of the IndexCleaner completely. I think ti > > might be better to move it into the KCM, and only run it when the > > configuration changes. There isn't much point running it ea

Re: Review Request 114983: Misc changes to the file queue

2014-01-12 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114983/#review47256 --- Ship it! This is awesome. Ship it! If you want you can also g

Review Request 114983: Misc changes to the file queue

2014-01-12 Thread Simeon Bird
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114983/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti