Re: Review Request 114816: Optimize Baloo indexing

2014-01-03 Thread Benjamin Kaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114816/ --- (Updated Jan. 3, 2014, 11:11 a.m.) Status -- This change has been ma

Re: Review Request 114816: Optimize Baloo indexing

2014-01-03 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114816/#review46678 --- Ship it! Look good. - Vishesh Handa On Jan. 3, 2014, 10:30

Re: Review Request 114816: Optimize Baloo indexing

2014-01-03 Thread Benjamin Kaiser
> On Jan. 3, 2014, 9:33 a.m., Vishesh Handa wrote: > > src/file/fileindexingjob.cpp, line 50 > > > > > > Ideally, I would have liked for this code which checks if the file > > exists to be moved to the extractor.

Re: Review Request 114816: Optimize Baloo indexing

2014-01-03 Thread Benjamin Kaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114816/ --- (Updated Jan. 3, 2014, 10:30 a.m.) Review request for Baloo and Vishesh H

Re: Review Request 114816: Optimize Baloo indexing

2014-01-03 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114816/#review46667 --- Well done. You're almost there. src/file/extractor/app.cpp <

Review Request 114816: Optimize Baloo indexing

2014-01-02 Thread Benjamin Kaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114816/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti