Re: Making KRDC's vnc fully threadsafe

2013-10-27 Thread Urs Wolfer
Shaheed, thanks for your work. I think you can push this patch to reviewboard where we can continue discussing it. IMHO this work should go into master since it's a quite large refactoring with new features. Bye urs On 2013-10-27 02:56, Shaheed Haque wrote: And here is the working code. Th

Re: Making KRDC's vnc fully threadsafe

2013-10-27 Thread Shaheed Haque
​I forgot to say: I have a KDE Git account. >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Making KRDC's vnc fully threadsafe

2013-10-27 Thread Shaheed Haque
That version is not 100% complete/working, it was more intended to give some idea of the direction. Given your approval in principle, I will work on it further. How would you like to work in terms of reviews/branches etc.? On 26 October 2013 19:27, Urs Wolfer wrote: > Hi Shaheed > > Thanks for

Re: Making KRDC's vnc fully threadsafe

2013-10-27 Thread Shaheed Haque
And here is the working code. There are a few kError() calls which could get converted into kDebug()s in due course. On 26 October 2013 20:38, Shaheed Haque wrote: > > ​I forgot to say: I have a KDE Git account. > vncclientthread.tgz Description: GNU Zip compressed data >> Visit http://mail

Making KRDC's vnc fully threadsafe

2013-10-26 Thread Shaheed Haque
Hi Urs, Christophe, I'm interested in trying to make KRDC's vnc client support automatic reconnection (using TCP keepalives). I had a quick hack and made some progress, but before trying the real thing, I need to make VncClientThread's "outputErrorMessageString" fully threadsafe. The attached pat

Re: Making KRDC's vnc fully threadsafe

2013-10-26 Thread Urs Wolfer
Hi Shaheed Thanks for this work. Looks good to me after a short look into it. I will look more deeply into it soon. Do you have a KDE Git account or should I commit it? I'm looking forward to you work for supporting automatic reconnection. Bye urs On 2013-10-26, Shaheed Haque wrote: Hi Urs