Re: Broken KRFB Build on non-linux platforms

2020-09-18 Thread Ben Cooksley
On Sat, Sep 19, 2020 at 6:23 AM Gleb Popov <6year...@gmail.com> wrote: > > > On Fri, Sep 18, 2020 at 10:16 PM Ben Cooksley wrote: > >> Hi Aleix, >> >> Recently you committed some Linux only changes to KRFB. Unfortunately >> these changes were not guar

Re: Broken KRFB Build on non-linux platforms

2020-09-18 Thread Gleb Popov
On Fri, Sep 18, 2020 at 10:16 PM Ben Cooksley wrote: > Hi Aleix, > > Recently you committed some Linux only changes to KRFB. Unfortunately > these changes were not guarded accordingly, and have therefore broken the > build on all other platforms (FreeBSD in particular). >

Broken KRFB Build on non-linux platforms

2020-09-18 Thread Ben Cooksley
Hi Aleix, Recently you committed some Linux only changes to KRFB. Unfortunately these changes were not guarded accordingly, and have therefore broken the build on all other platforms (FreeBSD in particular). Can you please correct this? As a side note, Pipewire is showing up far too often as a

Re: Krfb

2015-10-15 Thread Jeremy Whiting
5, a les 04:41:32, Jeremy Whiting va escriure: >> Yeah, that's the latest. I e-mailed Urs about krdc and mentioned krfb >> also. He suggested asking for a general review, so that's what this >> is now. > > Looks good to me, could not find anything wrong and

Re: Krfb

2015-10-10 Thread Albert Astals Cid
El Saturday 10 October 2015, a les 04:41:32, Jeremy Whiting va escriure: > Yeah, that's the latest. I e-mailed Urs about krdc and mentioned krfb > also. He suggested asking for a general review, so that's what this > is now. Looks good to me, could not find anything wrong and

Re: Krfb

2015-10-10 Thread Jeremy Whiting
Yeah, that's the latest. I e-mailed Urs about krdc and mentioned krfb also. He suggested asking for a general review, so that's what this is now. thanks, Jeremy On Sat, Oct 10, 2015 at 3:26 AM, Albert Astals Cid wrote: > El Friday 09 October 2015, a les 10:40:56, Jeremy Whitin

Re: Krfb

2015-10-10 Thread Albert Astals Cid
El Friday 09 October 2015, a les 10:40:56, Jeremy Whiting va escriure: > Hello all, > > I've ported Krfb to kf5/qt5 on the frameworks branch. Last commit is September 17, did you forget to push some stuff or this is an email you wanted to write a while ago? Cheers, Albert

Krfb

2015-10-09 Thread Jeremy Whiting
Hello all, I've ported Krfb to kf5/qt5 on the frameworks branch. It seems to work well here, but I am not the maintainer so thought it would be good if others can take a look at the code also. If one or two people would give it a try I would appreciate it. I'd like to merge frameworks