Re: Feedback on CMakeLists.txt changes

2010-11-09 Thread Jeffery MacEachern
On Tue, Nov 9, 2010 at 18:58, Raphael Kubo da Costa wrote: > On Wednesday 10 November 2010 00:16:43 Jeffery MacEachern wrote: >> Hi all, >> >> I'm planning to commit a patch[0] to KNotify shortly, but I am >> uncertain of whether or not my edits to the CMakeLists.txt file are >> done The Right Way

Re: Feedback on CMakeLists.txt changes

2010-11-09 Thread Raphael Kubo da Costa
On Wednesday 10 November 2010 00:16:43 Jeffery MacEachern wrote: > Hi all, > > I'm planning to commit a patch[0] to KNotify shortly, but I am > uncertain of whether or not my edits to the CMakeLists.txt file are > done The Right Way (it builds fine, but I suspect I've missed some > finer points).

Feedback on CMakeLists.txt changes

2010-11-09 Thread Jeffery MacEachern
Hi all, I'm planning to commit a patch[0] to KNotify shortly, but I am uncertain of whether or not my edits to the CMakeLists.txt file are done The Right Way (it builds fine, but I suspect I've missed some finer points). Could someone take a brief glance and let me know if I've made any newbie m