Re: Code Review: Spectacle

2019-05-06 Thread Nate Graham
On Sun, 05 May 2019 14:49:11 -0600 Reindl Harald wrote > > * right next to delay there is a checkbox all the time "on click" > > * you can switch that checkbox on for years (at least on Fedora) > > * but it makes no sense apply it for every mode > > * when i select a rectangle from

Re: Code Review: Spectacle

2019-05-05 Thread Reindl Harald
Am 05.05.19 um 22:44 schrieb Reindl Harald: > > > Am 05.05.19 um 22:39 schrieb Nate Graham: >> On Sun, 05 May 2019 14:16:01 -0600 Reindl Harald >> wrote >> > Am 05.05.19 um 22:12 schrieb Nate Graham: >> > > As of 19.04, this is now an optional but off-by-default feature. Feel >>

Re: Code Review: Spectacle

2019-05-05 Thread Reindl Harald
Am 05.05.19 um 22:49 schrieb Reindl Harald > Am 05.05.19 um 22:44 schrieb Reindl Harald: >> >> >> Am 05.05.19 um 22:39 schrieb Nate Graham: >>> On Sun, 05 May 2019 14:16:01 -0600 Reindl Harald >>> wrote >>> > Am 05.05.19 um 22:12 schrieb Nate Graham: >>> > > As of 19.04, this is no

Re: Code Review: Spectacle

2019-05-05 Thread Nate Graham
On Sun, 05 May 2019 14:44:14 -0600 Reindl Harald wrote > what are you talking about? > > * right next to delay there is a checkbox all the time "on click" > * you can switch that checkbox on for years (at least on Fedora) > * but it makes no sense apply it for every mode > * whe

Re: Code Review: Spectacle

2019-05-05 Thread Reindl Harald
Am 05.05.19 um 22:39 schrieb Nate Graham: > On Sun, 05 May 2019 14:16:01 -0600 Reindl Harald > wrote > > Am 05.05.19 um 22:12 schrieb Nate Graham: > > > As of 19.04, this is now an optional but off-by-default feature. Feel > free to turn it on. :) > > > > that's not the point

Re: Code Review: Spectacle

2019-05-05 Thread Nate Graham
On Sun, 05 May 2019 14:16:01 -0600 Reindl Harald wrote > Am 05.05.19 um 22:12 schrieb Nate Graham: > > As of 19.04, this is now an optional but off-by-default feature. Feel free > > to turn it on. :) > > that's not the point > > the point is that it makes sense for everything

Re: Code Review: Spectacle

2019-05-05 Thread Reindl Harald
Am 05.05.19 um 22:12 schrieb Nate Graham: > On Sun, 05 May 2019 13:57:49 -0600 Reindl Harald > wrote > > > > > > Am 05.05.19 um 21:44 schrieb Boudhayan Gupta: > > > Hi folks, > > > > > > I've been hacking on Spectacle again :-P > > > > if you are at it please bring back

Re: Code Review: Spectacle

2019-05-05 Thread Nate Graham
Thanks! Looks promising so far. A Phab review would be lovely, yes. Nate On Sun, 05 May 2019 13:44:24 -0600 Boudhayan Gupta wrote > Hi folks, > I've been hacking on Spectacle again :-P > I wanted to refactor the platform backends to make it a little bit cleaner > and more state

Re: Code Review: Spectacle

2019-05-05 Thread Nate Graham
On Sun, 05 May 2019 13:57:49 -0600 Reindl Harald wrote > > > Am 05.05.19 um 21:44 schrieb Boudhayan Gupta: > > Hi folks, > > > > I've been hacking on Spectacle again :-P > > if you are at it please bring back the sane behavior of "ksnapshot" to > make "remember selection"

Re: Code Review: Spectacle

2019-05-05 Thread Reindl Harald
Am 05.05.19 um 21:44 schrieb Boudhayan Gupta: > Hi folks, > > I've been hacking on Spectacle again :-P if you are at it please bring back the sane behavior of "ksnapshot" to make "remember selection" default *but not* between sessions that worked so fine for all the years when you had to docu

Code Review: Spectacle

2019-05-05 Thread Boudhayan Gupta
Hi folks, I've been hacking on Spectacle again :-P I wanted to refactor the platform backends to make it a little bit cleaner and more stateless, and also factor out invoking the rectangular cropper from the platform backend - so that it's now invoked by SpectacleCore rather than the backend. But