Re: [PATCH 1/2] Fix URL parsing

2016-05-29 Thread Thiago Macieira
Em sábado, 28 de maio de 2016, às 15:37:53 BRT, Arno escreveu: > Hi Thiago, > > On 5/28/2016 3:01 PM, Thiago Macieira wrote: > > Em sábado, 28 de maio de 2016, às 01:08:24 BRT, Arno Moeller escreveu: > >> As it seems, QUrl does not know about rdp://, so url.scheme() is empty. > >> The old code tri

Re: [PATCH 1/2] Fix URL parsing

2016-05-29 Thread Arno
Hi Harald, On 5/29/2016 11:30 AM, Harald Sitter wrote: > You told it to construct a url from a local file path, so, that seems > somewhat expected. > > I'd presume what you should use is > http://doc.qt.io/qt-5/qurl.html#fromUserInput which should usually > make sense out of most random input. Y

Re: [PATCH 1/2] Fix URL parsing

2016-05-29 Thread Harald Sitter
On Sat, May 28, 2016 at 3:22 PM, Arno wrote: > Hi Thiago, > > On 5/28/2016 3:01 PM, Thiago Macieira wrote: >> Em sábado, 28 de maio de 2016, às 01:08:24 BRT, Arno Moeller escreveu: >>> As it seems, QUrl does not know about rdp://, so url.scheme() is empty. >>> The old code tried to "fix" it by rep

Re: [PATCH 1/2] Fix URL parsing

2016-05-28 Thread Arno
Hi Thiago, On 5/28/2016 3:01 PM, Thiago Macieira wrote: > Em sábado, 28 de maio de 2016, às 01:08:24 BRT, Arno Moeller escreveu: >> As it seems, QUrl does not know about rdp://, so url.scheme() is empty. >> The old code tried to "fix" it by replacing the scheme with vnc://, >> because, as the comm

Re: [PATCH 1/2] Fix URL parsing

2016-05-28 Thread Thiago Macieira
Em sábado, 28 de maio de 2016, às 01:08:24 BRT, Arno Moeller escreveu: > As it seems, QUrl does not know about rdp://, so url.scheme() is empty. > The old code tried to "fix" it by replacing the scheme with vnc://, > because, as the comment stated, it was default in kde3. That doesn't make sense.

[PATCH 1/2] Fix URL parsing

2016-05-27 Thread Arno Moeller
From: Arno As it seems, QUrl does not know about rdp://, so url.scheme() is empty. The old code tried to "fix" it by replacing the scheme with vnc://, because, as the comment stated, it was default in kde3. Fix the "fix" by explicitly looking for supported schemes (vnc://, rdp:// and nx://, are