Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-15 Thread Chirag Anand
Updated the review request #102328. Added another patch to include KIntSpinBox to the rename dialog. It looks a little off, may be need to decrease the width? -- Regards Chirag Anand >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-15 Thread Chirag Anand
On Aug 15 12:04, Peter Penz wrote: > On Sunday 14 August 2011 21:22:23 Chirag Anand wrote: > [...] > > > > Yes its a better idea indeed, removes ambiguity and leaves us with the > > > > well-tested code. KIntSpinBox will solve our problem. And with this, the > > > > user will be able to rename file

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-15 Thread Chirag Anand
On Aug 15 22:58, Ben Cooksley wrote: > On Mon, Aug 15, 2011 at 10:50 PM, Chirag Anand wrote: > > On Aug 15 22:27, Ben Cooksley wrote: > > > >> >> I did create an account on identity.kde.org, but for some strange reason > >> >> it is not working, not on identity and not on reviewboard too. I got i

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-15 Thread Ben Cooksley
On Mon, Aug 15, 2011 at 10:50 PM, Chirag Anand wrote: > On Aug 15 22:27, Ben Cooksley wrote: > >> >> I did create an account on identity.kde.org, but for some strange reason >> >> it is not working, not on identity and not on reviewboard too. I got it >> >> activated through the link, and even ch

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-15 Thread Chirag Anand
On Aug 15 22:27, Ben Cooksley wrote: > >> I did create an account on identity.kde.org, but for some strange reason > >> it is not working, not on identity and not on reviewboard too. I got it > >> activated through the link, and even changed my password again. Its > >> showing check the username/p

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-15 Thread Chirag Anand
On Aug 15 12:04, Peter Penz wrote: > On Sunday 14 August 2011 21:22:23 Chirag Anand wrote: > [...] > > > > Yes its a better idea indeed, removes ambiguity and leaves us with the > > > > well-tested code. KIntSpinBox will solve our problem. And with this, the > > > > user will be able to rename file

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-15 Thread Ben Cooksley
On Mon, Aug 15, 2011 at 10:04 PM, Peter Penz wrote: > On Sunday 14 August 2011 21:22:23 Chirag Anand wrote: > [...] >> > > Yes its a better idea indeed, removes ambiguity and leaves us with the >> > > well-tested code. KIntSpinBox will solve our problem. And with this, the >> > > user will be able

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-15 Thread Peter Penz
On Sunday 14 August 2011 21:22:23 Chirag Anand wrote: [...] > > > Yes its a better idea indeed, removes ambiguity and leaves us with the > > > well-tested code. KIntSpinBox will solve our problem. And with this, the > > > user will be able to rename files with different extensions in a > > > sequen

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-14 Thread Chirag Anand
On Aug 14 21:05, Peter Penz wrote: > Hi, > > On Sunday 14 August 2011 20:39:38 Chirag Anand wrote: > > On Aug 14 12:07, Peter Penz wrote: > > > Hello, > > > > > > thanks for the patch! I like the idea that the user can configure the > > > start-index for renaming but (at least I) was confused wi

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-14 Thread Peter Penz
Hi, On Sunday 14 August 2011 20:39:38 Chirag Anand wrote: > On Aug 14 12:07, Peter Penz wrote: > > Hello, > > > > thanks for the patch! I like the idea that the user can configure the > > start-index for renaming but (at least I) was confused with the "(000)" > > string and was not sure whether

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-14 Thread Chirag Anand
On Aug 14 12:07, Peter Penz wrote: > Hello, > > thanks for the patch! I like the idea that the user can configure the > start-index for renaming but (at least I) was confused with the "(000)" > string and was not sure whether the parenthesis will get now part of the > name. Also I was not sure

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-14 Thread Peter Penz
Hello, thanks for the patch! I like the idea that the user can configure the start-index for renaming but (at least I) was confused with the "(000)" string and was not sure whether the parenthesis will get now part of the name. Also I was not sure whether the numbering will start with 0 or 1 (I

Re: [PATCH] Modified Dolphin multiple files renaming functionality

2011-08-14 Thread Raphael Kubo da Costa
Chirag Anand writes: > This patch applies to dolphin/src/views/renamedialog.cpp and > dolphin/src/views/renamedialog.h. It is built on the current master > branch of kde-baseapps repository. It would be better if you could send the patch via ReviewBoard (https://git.reviewboard.kde.org), as ther

[PATCH] Modified Dolphin multiple files renaming functionality

2011-08-13 Thread Chirag Anand
Hello, This patch applies to dolphin/src/views/renamedialog.cpp and dolphin/src/views/renamedialog.h. It is built on the current master branch of kde-baseapps repository. It replaces the current renaming functionality of Dolphin for multiple files. The functionality gives user a little more contr