Re: [Development] kdelibs coding style

2013-04-30 Thread Mitch Curtis
On 04/29/2013 10:31 PM, Olivier Goffart wrote: I support the change to optionally permit the braces. +1. Have always disliked this particular style. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: [Development] kdelibs coding style

2013-04-29 Thread Giuseppe D'Angelo
On 29 April 2013 21:20, Thiago Macieira wrote: > On segunda-feira, 29 de abril de 2013 18.52.16, Giuseppe D'Angelo wrote: >> On 29 April 2013 18:43, Thiago Macieira wrote: >> > With that in mind, I would suggest we change *both* coding styles to >> > optionally permit the braces, and strongly sug

Re: [Development] kdelibs coding style

2013-04-29 Thread Olivier Goffart
On Monday 29 April 2013 09:43:55 Thiago Macieira wrote: > On segunda-feira, 29 de abril de 2013 17.16.49, Sergio Martins wrote: > > The thing is, I just discovered that the kdelibs style[1] has a little > > difference from Qt, it uses braces for one-line if statements. > > > > This seems to be a d

Re: [Development] kdelibs coding style

2013-04-29 Thread Thiago Macieira
On segunda-feira, 29 de abril de 2013 18.52.16, Giuseppe D'Angelo wrote: > On 29 April 2013 18:43, Thiago Macieira wrote: > > With that in mind, I would suggest we change *both* coding styles to > > optionally permit the braces, and strongly suggest it for more-complex > > conditionals. > > In Qt

Re: [Development] kdelibs coding style

2013-04-29 Thread Giuseppe D'Angelo
On 29 April 2013 18:43, Thiago Macieira wrote: > > With that in mind, I would suggest we change *both* coding styles to > optionally permit the braces, and strongly suggest it for more-complex > conditionals. In Qt the braces are already mandatory if the condition spans over more than one line (w