Re: Review Request 127178: Added writer plugin support

2016-04-10 Thread Varun Joshi
-CREATION src/writerplugin.h PRE-CREATION src/writerplugin.cpp PRE-CREATION src/writers/CMakeLists.txt PRE-CREATION src/writers/taglibwriter.h PRE-CREATION src/writers/taglibwriter.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127178/diff/ Testing --- Thanks, Varun

Re: Review Request 127368: [KFileMetaData] Added support for external writer plugins

2016-04-10 Thread Varun Joshi
/writers/externalwriters/pdfwriter/main.py PRE-CREATION src/writers/externalwriters/pdfwriter/manifest.json PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127368/diff/ Testing --- Thanks, Varun Joshi

Review Request 127368: [KFileMetaData] Added support for external writer plugins

2016-03-13 Thread Varun Joshi
/manifest.json PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127368/diff/ Testing --- Thanks, Varun Joshi

Re: Review Request 127178: Added writer plugin support

2016-03-03 Thread Varun Joshi
gt; > are getting? Lets find out why thats happening and try fixing them. Just > > comparing the size is not a decent test. > > Varun Joshi wrote: > https://paste.kde.org/phqjgjxo4 : This is what I get. I had asked around > earlier but hadn't found a solution

Re: Review Request 127178: Added writer plugin support

2016-03-01 Thread Varun Joshi
tion then, so size was a stopgap measure - Varun --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127178/#review92981 ------

Re: Review Request 127178: Added writer plugin support

2016-02-28 Thread Varun Joshi
marked as submitted. Review request for Baloo, Boudhayan Gupta and Vishesh Handa. Changes --- Submitted with commit 8941ccc5e2567e63dbb5f24c7661e47a676725fd by Varun Joshi to branch externalextractors. Repository: kfilemetadata Description --- 1. Added the Writer class similar to

Re: Review Request 127178: Added writer plugin support

2016-02-28 Thread Varun Joshi
PRE-CREATION src/writers/CMakeLists.txt PRE-CREATION src/writers/taglibwriter.h PRE-CREATION src/writers/taglibwriter.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127178/diff/ Testing --- Thanks, Varun Joshi

Re: Review Request 127179: Add external extractor plugin support

2016-02-26 Thread Varun Joshi
PRE-CREATION src/extractors/externalextractors/pdfextractor/manifest.json PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127179/diff/ Testing --- Thanks, Varun Joshi

Re: Review Request 127179: Add external extractor plugin support

2016-02-26 Thread Varun Joshi
r::ExternalExtractorPrivate*'` ^ - Varun --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/#review92816 -------

Re: Review Request 127179: Add external extractor plugin support

2016-02-26 Thread Varun Joshi
/externalextractors/pdfextractor/manifest.json PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127179/diff/ Testing --- Thanks, Varun Joshi

Re: Review Request 127179: Add external extractor plugin support

2016-02-26 Thread Varun Joshi
-CREATION src/extractors/externalextractors/pdfextractor/manifest.json PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127179/diff/ Testing --- Thanks, Varun Joshi

Re: Review Request 127179: Add external extractor plugin support

2016-02-26 Thread Varun Joshi
of plugins asynchronously. What do you think? - Varun --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/#review92783 -------

Re: Review Request 127179: Add external extractor plugin support

2016-02-25 Thread Varun Joshi
/externalextractors/CMakeLists.txt PRE-CREATION src/extractors/externalextractors/pdfextractor/main.py PRE-CREATION src/extractors/externalextractors/pdfextractor/manifest.json PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127179/diff/ Testing --- Thanks, Varun Joshi

Review Request 127179: Add extractor plugin support

2016-02-25 Thread Varun Joshi
PRE-CREATION src/extractors/externalextractors/pdfextractor/manifest.json PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127179/diff/ Testing --- Thanks, Varun Joshi

Re: Review Request 127179: Add external extractor plugin support

2016-02-25 Thread Varun Joshi
/extractors/externalextractors/CMakeLists.txt PRE-CREATION src/extractors/externalextractors/pdfextractor/main.py PRE-CREATION src/extractors/externalextractors/pdfextractor/manifest.json PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127179/diff/ Testing --- Thanks, Varun Joshi

Review Request 127178: Added writer plugin support

2016-02-25 Thread Varun Joshi
/127178/diff/ Testing --- Thanks, Varun Joshi

Re: Review Request 127158: Adds writer and external (extractor and writer) plugin support

2016-02-24 Thread Varun Joshi
src/writers/taglibwriter.h PRE-CREATION src/writers/taglibwriter.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127158/diff/ Testing --- Created a sample PDF reader and extractor in Python, both of which work successfully. Thanks, Varun Joshi

Re: Review Request 127158: Adds writer and external (extractor and writer) plugin support

2016-02-23 Thread Varun Joshi
src/writers/taglibwriter.h PRE-CREATION src/writers/taglibwriter.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127158/diff/ Testing --- Created a sample PDF reader and extractor in Python, both of which work successfully. Thanks, Varun Joshi

Review Request 127158: Adds writer and external (extractor and writer) plugin support

2016-02-23 Thread Varun Joshi
src/writers/taglibwriter.h PRE-CREATION src/writers/taglibwriter.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127158/diff/ Testing --- Created a sample PDF reader and extractor in Python, both of which work successfully. Thanks, Varun Joshi

Re: [kde-community] Sprint: Reorganize the wikis

2015-12-10 Thread Varun Joshi
Hi, If there's any way I could help, I'd like to participate (remotely) too! Regards, Varun Joshi >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125650: Added exclude mimetypes to balooctl's control

2015-10-18 Thread Varun Joshi
marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 6f5b25305974e2ad1a408d4f3365dabc7456ad02 by Vishesh Handa on behalf of Varun Joshi to branch master. Repository: baloo Description --- Changed FileIndexerConfig to expose exclude

Re: Review Request 125650: Added exclude mimetypes to balooctl's control

2015-10-17 Thread Varun Joshi
/diff/ Testing --- Tested by adding and removing mimetypes via balooctl Thanks, Varun Joshi >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125650: Added exclude mimetypes to balooctl's control

2015-10-17 Thread Varun Joshi
--- Tested by adding and removing mimetypes via balooctl Thanks, Varun Joshi >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125650: Added exclude mimetypes to balooctl's control

2015-10-17 Thread Varun Joshi
it it for me. Thanks! - Varun --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125650/#review86952 --- On Oct. 16, 20

Re: Review Request 125650: Added exclude mimetypes to balooctl's control

2015-10-16 Thread Varun Joshi
src/file/fileindexerconfig.cpp 949ceb2 src/lib/indexerconfig.h d15c2e9 src/lib/indexerconfig.cpp 108390b src/tools/balooctl/configcommand.cpp 460e318 Diff: https://git.reviewboard.kde.org/r/125650/diff/ Testing --- Tested by adding and removing mimetypes via balooctl Thanks, Varun