Re: Review Request 119543: Removed all KDialogs from balooWidgets

think it is not needed. > I am not a fan of class members. you didnt see the dataflow. > We should i use a QScopedPointer? > > Thomas Braxton wrote: > Or you could just make it not a pointer and it cleans itself up. > > Felix Eisele wrote: > Good idea! > >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

think it is not needed. > I am not a fan of class members. you didnt see the dataflow. > We should i use a QScopedPointer? > > Thomas Braxton wrote: > Or you could just make it not a pointer and it cleans itself up. > > Felix Eisele wrote: > Good idea! > >

Re: Review Request 119543: Removed all KDialogs from balooWidgets

> On July 30, 2014, 8:54 a.m., Vishesh Handa wrote: > > src/tagwidget.cpp, line 180 > > > > > > Any reason you've combined the too functions? I don't remember why, but > > there was a point when it split up. > >

Re: Review Request 118231: Scheduler for the akonadi indexer.

g/r/118231/#comment41743> Couldn't they just not be pointers? Then you don't have to worry about deleting them. - Thomas Braxton On June 3, 2014, 11:18 p.m., Christian Mollekopf wrote: > > --- > This is an automatic

Re: Baloo - [Basic Settings]

On Wed, Apr 23, 2014 at 4:54 PM, Michael Pyne wrote: > On Wed, April 23, 2014 22:43:19 mk-li...@email.de wrote: > > Hi Vishesh, > > > > On 23 Apr 2014, at 11:44 , Vishesh Handa wrote: > > > [1] http://community.kde.org/Baloo/Configuration > > > > is there a reason why this page isn’t linked on >

Re: Review Request 115878: File: Add a thin wrapper around different xattr implementations.

tps://git.reviewboard.kde.org/r/115878/#comment35526> why not change the path and name parameters to QByteArray/QString? and value to QByteArray. it would look cleaner if you don't have to use data()/constData() all over the place, just in the implementation. - Thomas Braxton On Feb. 18, 2014