Re: Review Request 115053: If indexing a file which no longer exists, remove it from the FileMapping db as well as the xapian db

2014-01-16 Thread Simeon Bird
Diff: https://git.reviewboard.kde.org/r/115053/diff/ Testing --- Ran with it, but probably not exercised this code too much. Thanks, Simeon Bird >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 115053: If indexing a file which no longer exists, remove it from the FileMapping db as well as the xapian db

2014-01-16 Thread Simeon Bird
not exercised this code too much. Thanks, Simeon Bird >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 115007: Remove indexcleaner

2014-01-14 Thread Simeon Bird
/115007/diff/ Testing --- Not really - the cleaner does nothing anyway right now. Thanks, Simeon Bird >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 115006: Fix a potential infinite indexing loop

2014-01-14 Thread Simeon Bird
end us) Diffs - src/file/extractor/app.cpp 456f83a Diff: https://git.reviewboard.kde.org/r/115006/diff/ Testing --- It fixed my infinite loop! Thanks, Simeon Bird >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 115006: Fix a potential infinite indexing loop

2014-01-14 Thread Simeon Bird
it.reviewboard.kde.org/r/115006/#review47359 --- On Jan. 14, 2014, 12:14 a.m., Simeon Bird wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 115007: Remove indexcleaner

2014-01-14 Thread Simeon Bird
://git.reviewboard.kde.org/r/115007/diff/ Testing --- Not really - the cleaner does nothing anyway right now. Thanks, Simeon Bird >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 115007: Remove indexcleaner

2014-01-13 Thread Simeon Bird
Description --- Remove the indexcleaner from indexscheduler, as discussed Diffs - src/file/extractor/app.cpp 456f83a Diff: https://git.reviewboard.kde.org/r/115007/diff/ Testing --- Not really - the cleaner does nothing anyway right now. Thanks, Simeon Bird >> Visi

Review Request 115006: Fix a potential infinite indexing loop

2014-01-13 Thread Simeon Bird
g/r/115006/diff/ Testing --- It fixed my infinite loop! Thanks, Simeon Bird >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 114983: Misc changes to the file queue

2014-01-13 Thread Simeon Bird
marked as submitted. Review request for Baloo and Vishesh Handa. Repository: baloo Description --- Misc. File queue changes - the top edit should perhaps be applied to IndexScheduler::slotCommitted as well. commit ea35771246890c46f63d30f765a0d19844bd3d63 Author: Simeon Bird Date: Sat

Re: Review Request 114981: Rework slotScheduleIndexing a bit to fix some corner cases

2014-01-13 Thread Simeon Bird
things that turn up when I do this; the IndexCleaner stuff is a bit pointless, because the IndexCleaner does nothing right now. commit be744870904645be78f50bd51b186805e8c902ed Author: Simeon Bird Date: Sat Jan 11 16:25:51 2014 -0500 Fix up the IndexCleaner so that it starts suspended, then

Re: Review Request 114983: Misc changes to the file queue

2014-01-13 Thread Simeon Bird
isn't much point running it each time. > > Simeon Bird wrote: > Thanks! > > Do you mean remove IndexCleaner from the IndexScheduler, and have the KCM > do something like this, for a cleaner which is implemented, and can clean > specific paths: >

Re: Review Request 114983: Misc changes to the file queue

2014-01-12 Thread Simeon Bird
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114983/#review47256 --- On Jan. 12, 2014, 3:43 p.m., Simeon Bird wrote: > >

Re: Review Request 114981: Rework slotScheduleIndexing a bit to fix some corner cases

2014-01-12 Thread Simeon Bird
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114981/#review47257 ------- On Jan. 12, 2014, 3:43 p.m., Simeon Bird wrote: > > ---

Review Request 114983: Misc changes to the file queue

2014-01-12 Thread Simeon Bird
Description --- Misc. File queue changes - the top edit should perhaps be applied to IndexScheduler::slotCommitted as well. commit ea35771246890c46f63d30f765a0d19844bd3d63 Author: Simeon Bird Date: Sat Jan 11 14:57:39 2014 -0500 Instead of unconditionally resuming the file queue when the

Review Request 114981: Rework slotScheduleIndexing a bit to fix some corner cases

2014-01-12 Thread Simeon Bird
IndexCleaner does nothing right now. commit be744870904645be78f50bd51b186805e8c902ed Author: Simeon Bird Date: Sat Jan 11 16:25:51 2014 -0500 Fix up the IndexCleaner so that it starts suspended, then set resume to just emitResult and finish instantly. This stops the cleaner hanging