Re: Review Request 125401: implement windows usermetadata

marked as submitted. Review request for Baloo and kdewin. Changes --- Submitted with commit da334383058cc72af032b811c6dda21d7b879f6d by Patrick R. Spendrin on behalf of Patrick Spendrin to branch master. Repository: kfilemetadata Description --- I implemented all the functions for

Re: Review Request 125401: implement windows usermetadata

r for other platforms Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125401: implement windows usermetadata

67e5017af92dd5744ed061eedc3c2834 > > Diff: https://git.reviewboard.kde.org/r/125401/diff/ > > > Testing > --- > > On Windows; since most of the code is ifdeffed anyway, it shouldn't matter > for other platforms > > > Thanks, > > Patrick Spendrin > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 125401: implement windows usermetadata

/usermetadata.cpp 28967287d67d3e15a548a4e3fda614568dc932a3 src/xattr_p.h 80ea4c7767e5017af92dd5744ed061eedc3c2834 Diff: https://git.reviewboard.kde.org/r/125401/diff/ Testing --- On Windows; since most of the code is ifdeffed anyway, it shouldn't matter for other platforms Thanks, Pa

Re: Review Request 117829: do not raise unknown signal on windows

://git.reviewboard.kde.org/r/117829/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

/ Testing --- msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

. Repository: baloo Description --- rename test as another exists with the same name Diffs - src/file/tests/CMakeLists.txt 52662c1515b07a79126d387241f192c3d46dab30 Diff: https://git.reviewboard.kde.org/r/117845/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin

Re: Review Request 117845: rename test as another exists with the same name

/ Testing --- msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117851: fix finding the dummy extractor

/fileindexingjob/CMakeLists.txt 3fc5b2b03ecfcec9cffa2510a00b7b161ebbf94a src/file/autotest/fileindexingjob/fileindexingjobtest.cpp 8a0ca84f74f622990766d737ee6a1b108dca9068 Diff: https://git.reviewboard.kde.org/r/117851/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visi

Re: Review Request 117845: rename test as another exists with the same name

the same directory (CMAKE_BINARY_DIR/bin) so overwriting each other. - Patrick --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117845/#review56842 -------

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

/autotest/fileindexerconfigutils.h ab52f3b Diff: https://git.reviewboard.kde.org/r/117832/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117851: fix finding the dummy extractor

3fc5b2b03ecfcec9cffa2510a00b7b161ebbf94a src/file/autotest/fileindexingjob/fileindexingjobtest.cpp 8a0ca84f74f622990766d737ee6a1b108dca9068 Diff: https://git.reviewboard.kde.org/r/117851/diff/ Testing (updated) --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel

Re: Review Request 117845: rename test as another exists with the same name

. Repository: baloo Description --- rename test as another exists with the same name Diffs - src/file/tests/CMakeLists.txt 4f186483a9644d7b8de84335929cda16ceff71f3 Diff: https://git.reviewboard.kde.org/r/117845/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin

Review Request 117851: fix finding the dummy extractor

/fileindexingjobtest.cpp 8a0ca84f74f622990766d737ee6a1b108dca9068 Diff: https://git.reviewboard.kde.org/r/117851/diff/ Testing --- Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

://git.reviewboard.kde.org/r/117845/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117846: make filesearchstoretest a console application

/file/search/autotest/CMakeLists.txt 836ef2bfb29562aa36d8ebca8678932e5f01e0f3 Diff: https://git.reviewboard.kde.org/r/117846/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a Diff: https://git.reviewboard.kde.org/r/117845/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117845: rename test as another exists with the same name

/CMakeLists.txt 7b914b2f6a9b37f5ed2397ef3cc9c38ec29aba0a Diff: https://git.reviewboard.kde.org/r/117845/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117845: make filesearchstoretest a console application

--- msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117846: make filesearchstoretest a console application

://git.reviewboard.kde.org/r/117846/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117826: check that the directories are actually really removed

: https://git.reviewboard.kde.org/r/117826/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117825: exclude check for extended attributes for Windows

://git.reviewboard.kde.org/r/117825/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117827: malloc_trim is a gnu extension

ents on it. Diffs - src/xapian/xapiandatabase.cpp 0478139 Diff: https://git.reviewboard.kde.org/r/117827/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117828: prevent ex/import in exported classes used in tests

ndows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117830: disable extended attributes support on windows

/xattrdetector.cpp 9bff838 Diff: https://git.reviewboard.kde.org/r/117830/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117832: use QFileInfo to also find hidden paths on windows

rd.kde.org/r/117832/#review56750 --- On April 28, 2014, 10:05 a.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 117830: disable extended attributes support on windows

isit: https://git.reviewboard.kde.org/r/117830/#review56737 --- On April 28, 2014, 9:58 a.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 117832: use QFileInfo to also find hidden paths on windows

/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117830: disable extended attributes support on windows

msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117829: do not raise unknown signal on windows

Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117828: prevent ex/import in exported classes used in tests

e/lib/autotests/CMakeLists.txt 95a0916 src/file/search/autotest/CMakeLists.txt eb058d2 src/file/tests/CMakeLists.txt 102c981 Diff: https://git.reviewboard.kde.org/r/117828/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinf

Review Request 117827: malloc_trim is a gnu extension

.kde.org/r/117827/diff/ Testing --- windows msvc 2010 Thanks, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117826: check that the directories are actually really removed

, Patrick Spendrin >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117825: exclude check for extended attributes for Windows

--- at the moment, extended attributes are not supported on windows. The headers do not exist as well, so the check fails all the time. Diffs - ConfigureChecks.cmake 34db1e4 Diff: https://git.reviewboard.kde.org/r/117825/diff/ Testing --- msvc 2010 Thanks, Patrick Spendrin