Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

nt, but I'm curious to see where I'm wrong. - Michael Stemle On Dec. 27, 2016, 5:34 a.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129605/#review101259 --- Ship it! Ship It! - Michael Stemle On Dec. 4, 2016, 4

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100694 --- Ship it! Ship It! - Michael Stemle On Nov. 7, 2016, 6

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100652 --- Ship it! Ship It! - Michael Stemle On Nov. 6, 2016

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

(line 169) <https://git.reviewboard.kde.org/r/129186/#comment67544> PEDANTIC QUESTION: Why do we `resize()` rather than just using `QByteArray((values.size() + 1) * 5, '\0')`? I get that it's effectively the same thing, but it seems like it would be more concise to use th

Question about Qt tests

So, I'm still getting used to the dpointer paradigm. Is anybody familiar with how to use QTest to simulate code paths dependent on values in the dpointer which have no exposed mutators? For instance, I have QApt::Transaction which has its dpointer, and its dpointer has a property "error". This pro