Re: Various CI build failures

2016-08-31 Thread Michael Palimaka
On 30/08/16 19:52, Ben Cooksley wrote: > Additionally, would anyone mind if CI coverage were dropped for the following: > > - libechonest Qt 5 branches I can't speak on behalf of whoever maintains this, but the Echo Nest API has been shutdown for some months now so I doubt coverage of this librar

Re: Review of special packager access

2016-07-08 Thread Michael Palimaka
check over their ~/.ssh/authorized keys > file and remove any outdated keys. I confirm that Gentoo is still active. Our primary contacts are: Johannes Huber Michael Palimaka We have also reviewed our ~/.ssh/authorized_keys. Kind regards, Michael

Re: Review Request 124949: Remove unused dependencies.

2015-08-30 Thread Michael Palimaka
marked as submitted. Review request for Baloo. Changes --- Submitted with commit 53e6f2e52512124f141b0faf71cf1ba83ec4501a by Michael Palimaka to branch master. Repository: baloo-widgets Description --- I can't find any usage of KF5Service or KF5Completion. KF5KDELibs4Support is

Review Request 124949: Remove unused dependencies.

2015-08-27 Thread Michael Palimaka
p.cpp 4379e96ac51168b20b6384a89a5cc326eb14fe42 Diff: https://git.reviewboard.kde.org/r/124949/diff/ Testing --- Builds, inspected source. Thanks, Michael Palimaka >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 118996: Mark tests.

2014-06-29 Thread Michael Palimaka
://git.reviewboard.kde.org/r/118996/diff/ Testing --- Thanks, Michael Palimaka >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 118996: Mark tests.

2014-06-28 Thread Michael Palimaka
will cause them to be excluded from the default target if BUILD_TESTING is off (defaults to on). Diffs - lib/test/CMakeLists.txt 076ce2cadcdd38e7eaac29027e89291ae199737d Diff: https://git.reviewboard.kde.org/r/118996/diff/ Testing --- Thanks, Michael Palimaka >> Visi

Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

2014-06-12 Thread Michael Palimaka
le to run pim stuff in the same root as Plasma 2. - Michael Palimaka On June 11, 2014, 5:42 p.m., Bernd Steinhauser wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 118628: Make tests behave more like frameworks.

2014-06-10 Thread Michael Palimaka
- CMakeLists.txt aa2b0864ca8b2126ffcabf5cbad28b06dbb682b2 autotests/CMakeLists.txt 95c3e302122d3b9a01f70e74812c2b374ac46023 Diff: https://git.reviewboard.kde.org/r/118628/diff/ Testing --- Tests pass/are ignored with the appropriate build option. Thanks, Michael Palimaka >> Visi

Re: Review Request 118628: Make tests behave more like frameworks.

2014-06-10 Thread Michael Palimaka
> On June 10, 2014, 12:16 p.m., Bhushan Shah wrote: > > CMakeLists.txt, line 64 > > <https://git.reviewboard.kde.org/r/118628/diff/1/?file=279885#file279885line64> > > > > hmm what about using ecm_add_test? > > Michael Palimaka wrote: > That&

Re: Review Request 118628: Make tests behave more like frameworks.

2014-06-10 Thread Michael Palimaka
n autotests/CMakeLists.txt - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118628/#review59672 --- On June 9, 2

Review Request 118628: Make tests behave more like frameworks.

2014-06-09 Thread Michael Palimaka
95c3e302122d3b9a01f70e74812c2b374ac46023 Diff: https://git.reviewboard.kde.org/r/118628/diff/ Testing --- Tests pass/are ignored with the appropriate build option. Thanks, Michael Palimaka >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 118466: Make QtTest optional

2014-06-02 Thread Michael Palimaka
://git.reviewboard.kde.org/r/118466/diff/ Testing --- Builds and tests/not tests as expected. All tests conducted with KDEPIM_SUPPORT_BUILD off. Thanks, Michael Palimaka >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 118466: Make QtTest optional

2014-06-02 Thread Michael Palimaka
, visit: https://git.reviewboard.kde.org/r/118466/#review58987 --- On June 2, 2014, 11:03 a.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 118466: Make QtTest optional

2014-06-02 Thread Michael Palimaka
s parts. - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118466/#review58959 --- On June 2, 2014, 11:03 a.m., Mi

Review Request 118466: Make QtTest optional

2014-06-02 Thread Michael Palimaka
expected. All tests conducted with KDEPIM_SUPPORT_BUILD off. Thanks, Michael Palimaka >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<