There's a stack of diffs...

...waiting to be reviewed. Hi all! Please help baloo to (hopefully) improve and have a look at D11753 and its ancestors. Thanks in advance, Michael

Re: I need Unicode support

On 20.03.2018 19:34, Michael Heidelbach wrote: On 20.03.2018 16:41, ?? ?? wrote: I think baloo is a useful toolkit for file managing. But as a Chinese, I can't bare the lack of Chinese support of baloo. So could you tell me how to support unicode file indexing or fix this issue? than

Re: I need Unicode support

On 20.03.2018 16:41, ?? ?? wrote: I think baloo is a useful toolkit for file managing. But as a Chinese, I can't bare the lack of Chinese support of baloo. So could you tell me how to support unicode file indexing or fix this issue? thank you. Hi! I've just had a quick try searching for file

baloo needs to be notified of fuse mounts.

Hi! In order to fix bug 390830 (== baloo should not index plasma-vaults) I need a notification about mounts and unmounts of fuse.encfs filesystems (and maybe others). I've tried to find something suitable within Solid - without success so far. Can you give

Re: Would it be good if I became baloo's maintainer?

On 15.03.2018 11:07, Milian Wolff wrote: On Thursday, March 15, 2018 9:40:34 AM CET Michael Heidelbach wrote: Hi! Getting the stuff I do for baloo reviewed takes a lot of time and poking others. That is considerably slowing me down. I think it's good to make you the maintainer officially

Would it be good if I became baloo's maintainer?

Hi! Getting the stuff I do for baloo reviewed takes a lot of time and poking others. That is considerably slowing me down. I'm seriously thinking of becoming the maintainer for baloo (and maybe baloowidgets). Then it would be easier for me to commit those patches I consider as harmless e.g u

Re: Is it possible to mock an external drive (for unit testing)?

On 13.03.2018 17:37, Brüns, Stefan wrote: On Dienstag, 13. März 2018 15:38:54 CET Michael Heidelbach wrote: Thanks for your reply, Roman I also thought of archivemount but (maybe to early) discarded that idea because for testing I need control over the device id. I'm not sure how to

Re: Is it possible to mock an external drive (for unit testing)?

mount some archive and the files in the mountpoint will have another device id. Fuse must be available on the target OS of course. On Mon, Mar 12, 2018 at 12:27 PM, Michael Heidelbach mailto:ottw...@gmail.com>> wrote: Albert , I've been unspecific deliberately. Apparently t

Re: Is it possible to mock an external drive (for unit testing)?

2018, a les 18:27:51 CET, Michael Heidelbach va escriure: Hi! Is it? How? Do examples exist? You'll really need to be more specific, my initial answer would be, why would you care if something is a external drive? Cheers, Albert Thanks in advance, Michael

Re: Q_ASSERT(!FalseSecurity)

Got it. Thanks to you all, Michael On 10.03.2018 10:53, Albert Astals Cid wrote: El dissabte, 10 de març de 2018, a les 10:37:12 CET, Sven Brauch va escriure: Hi, On 03/10/2018 09:53 AM, Michael Heidelbach wrote: Am I getting something wrong? Or is "Q_ASSERT(m_write

Is it possible to mock an external drive (for unit testing)?

Hi! Is it? How? Do examples exist? Thanks in advance, Michael

Re: How to improve --help message?

A "Geistesblitz": I'm going to do it the same way akonadictl does. Other ideas are still very much appreciated. On 10.03.2018 10:30, Michael Heidelbach wrote: Hi! Currently balooctl's help looks like this: $ balooctl  ---help Usage: balooctl [options] command status

Re: March 15, 2018: KDE Applications 18.04 Dependency Freeze

l dissabte, 10 de març de 2018, a les 10:41:03 CET, Michael Heidelbach va escriure: On 10.03.2018 10:39, Albert Astals Cid wrote: So what the subject says, get your dependencies in ASAP. Cheers, Albert Hi Albert! What exactly is a dependency freeze? Should have included the link, my

Re: March 15, 2018: KDE Applications 18.04 Dependency Freeze

On 10.03.2018 10:39, Albert Astals Cid wrote: So what the subject says, get your dependencies in ASAP. Cheers, Albert Hi Albert! What exactly is a dependency freeze? Cheers, Michael

How to improve --help message?

Hi! Currently balooctl's help looks like this: $ balooctl  ---help Usage: balooctl [options] command status enable disable start stop restart suspend resume check index clear config monitor indexSize list

Q_ASSERT(!FalseSecurity)

Hi! Am I getting something wrong? Or is "Q_ASSERT(m_writeTrans); m_writeTrans->commit();" providing false security? Shouldn't it better be "Q_ASSERT(m_writeTrans); if (m_writeTrans) {     m_writeTrans->commit(); ? Baloo's code is full of Q_ASSERTs that have no correspondin

Re: Code in peace or How to lint a complete repository?

On 28.02.2018 22:41, Elvis Angelaccio wrote: On mercoledì 28 febbraio 2018 10:57:30 CET, Michael Heidelbach wrote: Hi! Now that I saw https://phabricator.kde.org/D10905, I want to do something similar for baloo and baloo-widgets. I'd really like to that once and for all. Because app

CI fails to build my last commit in a file I did not change

Hi! Applications baloo-widgets kf5-qt5 FreeBSDQt5.9/ What to do now? Cheers, Michael

Re: Code in peace or How to lint a complete repository?

On 28.02.2018 20:44, Nicolás Alvarez wrote: 2018-02-28 6:57 GMT-03:00 Michael Heidelbach : Hi! Now that I saw https://phabricator.kde.org/D10905, I want to do something similar for baloo and baloo-widgets. I'd really like to that once and for all. Because applying coding style on-th

Code in peace or How to lint a complete repository?

Hi! Now that I saw https://phabricator.kde.org/D10905, I want to do something similar for baloo and baloo-widgets. I'd really like to that once and for all. Because applying coding style on-the-fly obscures real changes introduced. 1. Would it be reasonable? 2. Who would be willing to revie

Re: Plasma Vault and BUG:390830

On 24.02.2018 15:27, Nate Graham wrote: Maybe automatically disable indexing for cryfs and encfs volumes, no matters where they live? Vault allows you to change the default location of your vault, I believe. Nate On 02/24/2018 01:57 AM, Michael Heidelbach wrote: Hi! The best option to fix

Plasma Vault and BUG:390830

Hi! The best option to fix this bug is by excluding Vaults from being searched by baloo. Do that, I need to know how to distinguish vaults from normal folders (and other mountpoints) On first glance it appears they are all under ~/Vaults, please confirm. What about localization? Cheers,

Please comment on T8054

It all said, except "Hi!" ... and maybe: C++-wise I'll be entering areas where I've never been before. ... and ... Cheers, Michael

Why does kdelibs4support/src/kio/kfilemetadatawidget still exist?

Hi! Looking at lxr.kde.org it seems like dolphin is the only "real" client of KFileMetaDataWidget. Dolphin is not using it because of #ifndef HAVE_BALOO     m_metaDataWidget = new KFileMetaDataWidget(parent); #else     m_metaDataWidget = new B

Re: How to temporarily change KConfig-data for a unit test?

On 13.02.2018 20:38, Martin Flöser wrote: Am 2018-02-13 15:42, schrieb Aleix Pol: On Tue, Feb 13, 2018 at 1:14 PM, Michael Heidelbach wrote: Hi! Currently I'm working on baloo-widgets. For a unit test I need to temporarily change KConfig data. My approach would be like this: initTes

Re: How to temporarily change KConfig-data for a unit test?

On 13.02.2018 15:42, Aleix Pol wrote: On Tue, Feb 13, 2018 at 1:14 PM, Michael Heidelbach wrote: Hi! Currently I'm working on baloo-widgets. For a unit test I need to temporarily change KConfig data. My approach would be like this: initTestCase() KConfig config("baloofileinf

How to temporarily change KConfig-data for a unit test?

Hi! Currently I'm working on baloo-widgets. For a unit test I need to temporarily change KConfig data. My approach would be like this: initTestCase()     KConfig config("baloofileinformationrc", KConfig::NoGlobals);     KConfigGroup settings = config.group("Show");         set everything to

Re: Baloo is not dead, it just smells a little funny

On 31.01.2018 23:55, Alexander Shaposhnikov wrote: Hello, I've been lurking arout for a while finding a place to start contributing to KDE, and this might be the project I was lurking for :) I'm fairly experienced in C++ and Qt, but not KDE, so I _might_ be useful. Just point me to the right p

Re: Baloo is not dead, it just smells a little funny

guide me, Thank you On Wed, Jan 31, 2018 at 7:00 PM, Michael Heidelbach <mailto:ottw...@gmail.com>> wrote: Perfect! Thank you. You made me happy, honestly. On 31.01.2018 17:53, Ben Cooksley wrote: On Thu, Feb 1, 2018 at 5:43 AM, Michael Heidelbach mail

Re: Baloo is not dead, it just smells a little funny

Perfect! Thank you. You made me happy, honestly. On 31.01.2018 17:53, Ben Cooksley wrote: On Thu, Feb 1, 2018 at 5:43 AM, Michael Heidelbach wrote: Hi! Hi Michael, Let me introduce myself first. When I started contributing to KDE with the beginning of this year this was the status: No

Baloo is not dead, it just smells a little funny

Hi! Let me introduce myself first. When I started contributing to KDE with the beginning of this year this was the status: * No experience in C++ at all * Wtr coding: No experience in collaboration and the technologies involved * No experience in many other things

Is it bad manners to refactor other people's code?

Hi! Currently I'm working on some code I couldn't understand until I split some long functions into smaller parts. As I couldn't find anything about the size-of-a-function topic in the KDE or Qt guide lines I consider this as a matter of personal taste. I don't want to step on anybody's toe

Dependent review requests

Hi! When I do git checkout -b A origin/master (changes) git checkout -b B A (changes) git checkout A arc diff git checkout B arc diff Will phabricator show the relation of A and B? Is that a reasonable approach, anyway? Michael