Re: Question about copyright notices

2020-09-25 Thread Matthieu Gallien
Hello, On mercredi 23 septembre 2020 19:35:26 CEST you wrote: > On Montag, 21. September 2020 22:32:37 CEST Matthieu Gallien wrote: > > Is there some consensus as to what is best for code hosted by the KDE > > community ? > > Hi, that is a good question! I cannot recall t

Question about copyright notices

2020-09-21 Thread Matthieu Gallien
Hello, I remember reading somewhere in the Internet that it is not useful or necessary to bump the year part of copyright notices. I did not manage to see if this indicated in https://community.kde.org/ Policies/Licensing_Policy Is there some consensus as to what is best for code hosted by the

Re: Building Elisa fails everytime

2020-09-21 Thread Matthieu Gallien
Hello, I am not currently using kdesrc but your failures are related to some KDE Frameworks. On lundi 21 septembre 2020 16:24:33 CEST Pavan Kumar wrote: > Hello > Today I was trying to build elisa "*kdesrc-build elisa*" but it failed with > a message > > <<< PACKAGES FAILED TO BUILD >>> > >

Re: Automated Tests and KConfig

2020-08-18 Thread Matthieu Gallien
Hello, On mardi 18 août 2020 01:42:29 CEST Albert Astals Cid wrote: > El dilluns, 17 d’agost de 2020, a les 23:57:20 CEST, Matthieu Gallien va escriure: > > Hello, > > > > I have been wandering if there is a general solution to use KConfig inside > > automated tests.

Automated Tests and KConfig

2020-08-17 Thread Matthieu Gallien
Hello, I have been wandering if there is a general solution to use KConfig inside automated tests. I have been having difficulties (and another contributor to Elisa) to integrate the singleton object lifetime with the need to run different tests isolated and using the singleton (including code

Re: Fixing license header

2018-09-12 Thread Matthieu Gallien
Hello, On mercredi 12 septembre 2018 12:54:42 CEST Harald Sitter wrote: > On Tue, Sep 11, 2018 at 5:34 PM Matthieu Gallien > > wrote: > > Hello, > > > > I have put a slightly incorrect license header at top of files. It is > > supposed to be LGPL v3 or later

Fixing license header

2018-09-11 Thread Matthieu Gallien
Hello, I have put a slightly incorrect license header at top of files. It is supposed to be LGPL v3 or later but contains a few errors and is not matching the one currently found on FSF site. I am not sure if it is necessary to ask explicit permissions from all contributors or if I can fix it

Re: Flatpak packaging for stable releases

2018-05-03 Thread Matthieu Gallien
Hello, On lundi 16 avril 2018 11:45:50 CEST you wrote: > On dimanche 15 avril 2018 01:52:41 CEST Aleix Pol wrote: > > On Sat, Apr 14, 2018 at 11:20 PM, Matthieu Gallien > > > > wrote: > > > Hello, > > > > > > I really appreciate the work th

Re: Flatpak packaging for stable releases

2018-04-16 Thread Matthieu Gallien
On dimanche 15 avril 2018 01:52:41 CEST Aleix Pol wrote: > On Sat, Apr 14, 2018 at 11:20 PM, Matthieu Gallien > > wrote: > > Hello, > > > > I really appreciate the work that has gone into flatpak and the excellent > > support for it in KDE and the KDE infrastr

Flatpak packaging for stable releases

2018-04-14 Thread Matthieu Gallien
supposed to also be used for stable releases. I have seen a few KDE applications being also hosted on flathub. Is this the way to go ? Best regards -- Matthieu Gallien

Re: Baloo is not dead, it just smells a little funny

2018-01-31 Thread Matthieu Gallien
Hello, On mercredi 31 janvier 2018 17:43:25 CET Michael Heidelbach wrote: > Hi! > > Let me introduce myself first. When I started contributing to KDE with > the beginning of this year this was the status: > > * No experience in C++ at all > * Wtr coding: No experience in collaboration and t

Re: Elisa runtime errors

2017-09-26 Thread Matthieu Gallien
Hello, On vendredi 22 septembre 2017 14:08:15 CEST Tomaz Canabrava wrote: > On Fri, Sep 22, 2017 at 1:57 PM, Tomaz Canabrava wrote: > > On Fri, Sep 22, 2017 at 12:06 PM, Matthieu Gallien < > > > > gallien.matth...@gmail.com> wrote: > >> Hello, > >> &

Re: Elisa runtime errors

2017-09-22 Thread Matthieu Gallien
Hello, Thanks for your report. I am always eager to get feedback being negative or positive. On vendredi 22 septembre 2017 11:55:27 CEST Tomaz Canabrava wrote: > Hello, > > I'm not sure if elisa has a mailing list, as I didn't found one. > I'm trying to run it for more than a month, it compiles

Re: Flatpak Qt/KDE runtime

2017-09-19 Thread Matthieu Gallien
Le 19 sept. 2017 17:16, "Aleix Pol" a écrit : On Tue, Sep 19, 2017 at 5:08 PM, Matthieu Gallien wrote: > Hello > > > Le 19 sept. 2017 17:00, "Aleix Pol" a écrit : > > Hi, > Recently flathub started building our runtime into their systems. I > recom

Re: Flatpak Qt/KDE runtime

2017-09-19 Thread Matthieu Gallien
Hello Le 19 sept. 2017 17:00, "Aleix Pol" a écrit : Hi, Recently flathub started building our runtime into their systems. I recommend using the runtimes there. I updated the wiki to reflect the change: https://community.kde.org/Guidelines_and_HOWTOs/Flatpak You will possibly have to remove and

kde-devel@kde.org

2017-08-23 Thread Matthieu Gallien
> On août 23, 2017, 7:23 après-midi, Christian Ehrlicher wrote: > > Anyone interested? Otherwise I'll discard this review in the next days I am interested but have no time right now. - Matthieu --- This is an automatically generated e-m

Re: Scrap Baloo Thread Feedback

2017-03-28 Thread Matthieu Gallien
Hello all, Sorry to exhume this old thread, but 2016-12-29 13:47 GMT+01:00 Dominik Haumann : > Hi all, > > CC: plasma-devel, due to stability issues > > On Fri, Oct 7, 2016 at 5:56 PM, Christoph Cullmann > wrote: >> Hi, >> > [...] >> Actually, the bugs.kde.org page tells you the facts: The bug

Re: Review Request 129925: fix build of kfilemetadata with taglib version 1.9

2017-02-05 Thread Matthieu Gallien
marked as submitted. Review request for Baloo and KDE Frameworks. Changes --- Submitted with commit 17aaf4ec09a5bf2e3c213cdfbcd3938c6c81c2cd by Matthieu Gallien to branch master. Repository: kfilemetadata Description --- fix build of kfilemetadata with taglib version 1.9 Diffs

Review Request 129925: fix build of kfilemetadata with taglib version 1.9

2017-02-05 Thread Matthieu Gallien
API exists in 1.9 version. Thanks, Matthieu Gallien

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
marked as submitted. Review request for Baloo. Changes --- Submitted with commit 6e64944bdbdad7a7d6e4262b390c8134c099fc46 by Matthieu Gallien to branch master. Repository: kfilemetadata Description --- the new property is appended at the end of the existing enums such that binary

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-02-05 Thread Matthieu Gallien
marked as submitted. Review request for Baloo and KDE Frameworks. Changes --- Submitted with commit 35ea63920a0398aa859b2944770fd9036c271166 by Matthieu Gallien to branch master. Repository: kfilemetadata Description --- Musepack extraction of album artist was using the wrong tag

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
why you're not moving DiscNumber to be before PropertyCount, as intended by > > this code? (remove the "= ..." value) > > Matthieu Gallien wrote: > To me, this seems to be part of public API of kfilemetadata and I thought > that changin the value of the enum coul

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
/ Testing --- Automatic tests are still all OK on my setup. I have modified my music player to makes use of it and it works. I have not yet any clear idea how to makes Baloo reindex the files to cache new properties. Thanks, Matthieu Gallien

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
isit: https://git.reviewboard.kde.org/r/129839/#review102409 ------- On Feb. 5, 2017, 2:32 p.m., Matthieu Gallien wrote: > > --- > This is an automatically generate

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
://git.reviewboard.kde.org/r/129839/diff/ Testing --- Automatic tests are still all OK on my setup. I have modified my music player to makes use of it and it works. I have not yet any clear idea how to makes Baloo reindex the files to cache new properties. Thanks, Matthieu Gallien

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-05 Thread Matthieu Gallien
> On Feb. 4, 2017, 7:59 p.m., Albert Astals Cid wrote: > > Any reason this has not been commited? > > Luigi Toscano wrote: > Because there was no final decision. > > It is true that the Baloo database can be regenerated, but I would say > that if we avoid a complete rebuild of the

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
/diff/ Testing --- Automatic tests are still all OK on my setup. I have modified my music player to makes use of it and it works. I have not yet any clear idea how to makes Baloo reindex the files to cache new properties. Thanks, Matthieu Gallien

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-02-05 Thread Matthieu Gallien
> On Feb. 5, 2017, 10:45 a.m., David Faure wrote: > > Patch looks ok to me, although I don't know much about all this. > > > > The real problem isn't tooling, but lack of active maintainership for > > kfilemetadata. Are you interested in taking over? >

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-02-05 Thread Matthieu Gallien
an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129798/#review102399 --- On Jan. 15, 2017, 4:03 p.m., Matthieu Gallien wrote: > > --- >

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-01 Thread Matthieu Gallien
? - Matthieu Gallien On Jan. 15, 2017, 4:01 p.m., Matthieu Gallien wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-02-01 Thread Matthieu Gallien
? - Matthieu Gallien On Jan. 15, 2017, 4:03 p.m., Matthieu Gallien wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-01-15 Thread Matthieu Gallien
problem in Musepack format against Easytag and Picard applications. Thanks, Matthieu Gallien

Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-01-15 Thread Matthieu Gallien
Baloo reindex the files to cache new properties. Thanks, Matthieu Gallien

Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-01-08 Thread Matthieu Gallien
extractors/taglibextractor.cpp 8fcad93ca4fc6572a412c1f729d1ef361dd7e8cf Diff: https://git.reviewboard.kde.org/r/129798/diff/ Testing --- I have tested with automatic tests of KFileMetaData and also the encoding problem in Musepack format against Easytag and Picard applications. Thanks, Matthieu Gallien

Re: Help about Baloo and refresh

2016-03-24 Thread Matthieu Gallien
le. I had a look at code (filewatch.cpp, extractor/app.cpp, ...) but was unable to locate such a dbus signal. Is it something I could write as a patch for baloo ? > > On Thu, Mar 17, 2016 at 5:46 PM, Matthieu Gallien > > wrote: > > Hello Vishesh and kde-devel, > > >

Help about Baloo and refresh

2016-03-19 Thread Matthieu Gallien
I am doing is modified). I did not found something like that. This is why I am asking for help on the best way to achieve that. Thanks in advance Best regards -- Matthieu Gallien