Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.

2014-06-26 Thread Matthew Dawson
7a07aa465601d4d196e9fa9158c05d1573d0f90d Diff: https://git.reviewboard.kde.org/r/118752/diff/ Testing --- Compiles and tests fine. Thanks, Matthew Dawson >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.

2014-06-25 Thread Matthew Dawson
explicit > > instead. This way it is obvious where it comes > > from. > > > > In this case I agree with the whole Python mantra of "Explicit is > > better than implicit" > > Matthew Dawson wrote: > I would have actually preferred to use th

Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.

2014-06-24 Thread Matthew Dawson
explicit > > instead. This way it is obvious where it comes > > from. > > > > In this case I agree with the whole Python mantra of "Explicit is > > better than implicit" > > Matthew Dawson wrote: > I would have actually preferred to use th

Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.

2014-06-17 Thread Matthew Dawson
. I can then start chasing down the problems with doing this change, and fix it later. - Matthew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118752/#review60251 -----------

Re: Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.

2014-06-16 Thread Matthew Dawson
7a07aa465601d4d196e9fa9158c05d1573d0f90d Diff: https://git.reviewboard.kde.org/r/118752/diff/ Testing --- Compiles and tests fine. Thanks, Matthew Dawson >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 118752: Fix Baloo to work against frameworkified KFileMetaData.

2014-06-14 Thread Matthew Dawson
fine. Thanks, Matthew Dawson >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<