Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-12-04 Thread Laurent Navet
> On Aug. 12, 2014, 11:33 a.m., Aleix Pol Gonzalez wrote: > > After some discussion with the SDK and Book groups in the sprint, I think > > we should move this into the kde:kwidgetsaddons repository, in an examples > > subdirectory. > > Laurent Navet wrote: >

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-12 Thread Laurent Navet
s from kdeexamples to kwidgetsaddons ? - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review64357 --- On août 12, 2014, 11:33

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-12 Thread Laurent Navet
commented the line. Thanks, Laurent Navet >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-11 Thread Laurent Navet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review63870 --- On août 4, 2014, 10:51 après-midi, Laurent Navet wrote: > >

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-05 Thread Laurent Navet
> On août 5, 2014, 8:20 matin, David Faure wrote: > > Looks good to me. I hope the commit log isn't the same as the reviewboard > > description though - it should be about what the patch does, instead. > > Laurent Navet wrote: > The commit log is : > --

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-05 Thread Laurent Navet
TextEdit - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review63828 --- On août 4, 2014, 10:51 après-midi,

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-08-04 Thread Laurent Navet
e(), as it don't exist in QTextEdit I've commented the line. Thanks, Laurent Navet >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-02-04 Thread Laurent Navet
ee what it really > > buy us for this example? > > > > Replacing it with kwidgetaddons - and maybe switch from kmainwindow to > > qmainwindow will make the example simpler. > > Laurent Navet wrote: > XmlGui replaced with KWidgetAddons and KConfigWidgets.

Review Request 115368: KF5 Port - Remove KDebug

2014-01-28 Thread Laurent Navet
--- Remove unneeded KDebug which is deprecated in KF5 Diffs - src/klettres.cpp 9f6ff3f src/klettresview.cpp d30be34 src/langutils.cpp b41ece2 src/soundfactory.cpp 27dad2e Diff: https://git.reviewboard.kde.org/r/115368/diff/ Testing --- build and run Thanks, Laurent

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-16 Thread Laurent Navet
QTextEdit I've commented the line. Thanks, Laurent Navet >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-15 Thread Laurent Navet
Widgets. switched from KMainWindow to QMainWindow. - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114933/#review47428 --------

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-10 Thread Laurent Navet
Testing --- Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've commented the line. Thanks, Laurent Navet >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

2014-01-09 Thread Laurent Navet
0 kdeui/kmessagewidgetdemo/window.h d3a67c8 kdeui/kmessagewidgetdemo/window.cpp 9786da6 Diff: https://git.reviewboard.kde.org/r/114933/diff/ Testing --- Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've commented the line. Thanks, Laurent Navet >>