Re: Review Request 123863: Encode and retrieve KFileMetaData::Type::Type from Document::m_data

529374a src/file/extractor/result.cpp 072aebc src/lib/CMakeLists.txt e0aad3f src/lib/file.h b92504b src/lib/file.cpp 13dff88 Diff: https://git.reviewboard.kde.org/r/123863/diff/ Testing --- All passed except #30 Thanks, John Freeman >> Visit http://mail.kde.org/m

Re: Review Request 123863: Encode and retrieve KFileMetaData::Type::Type from Document::m_data

/extractor/CMakeLists.txt 529374a src/file/extractor/result.cpp 072aebc src/lib/CMakeLists.txt e0aad3f src/lib/file.h b92504b src/lib/file.cpp 13dff88 Diff: https://git.reviewboard.kde.org/r/123863/diff/ Testing --- All passed except #30 Thanks, John Freeman >> Visi

Re: Review Request 123863: Encode and retrieve KFileMetaData::Type::Type from Document::m_data

: https://git.reviewboard.kde.org/r/123863/diff/ Testing --- All passed except #30 Thanks, John Freeman >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 123863: Encode and retrieve KFileMetaData::Type::Type from Document::m_data

/result.cpp 072aebc src/lib/file.h b92504b src/lib/file.cpp 13dff88 Diff: https://git.reviewboard.kde.org/r/123863/diff/ Testing --- All passed except #30 Thanks, John Freeman >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 123744: New Db for types, new codec for storing Types, and support in File for retrieving Types.

except #30 Thanks, John Freeman >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 123744: New Db for types, new codec for storing Types, and support in File for retrieving Types.

src/engine/writetransaction.cpp bae8ec0 src/file/basicindexingjob.h f5e64c8 src/file/basicindexingjob.cpp 70a9769 src/lib/file.h b92504b src/lib/file.cpp 13dff88 Diff: https://git.reviewboard.kde.org/r/123744/diff/ Testing --- All passed except #30 Thanks, John Freeman

Review Request 123744: New Db for types, new codec for storing Types, and support in File for retrieving Types.

src/file/basicindexingjob.h f5e64c8 src/file/basicindexingjob.cpp 70a9769 src/lib/file.h b92504b src/lib/file.cpp 13dff88 Diff: https://git.reviewboard.kde.org/r/123744/diff/ Testing --- All passed except #30 Thanks, John Freeman >> Visit http://mail.kde.org/mailman/li

Re: Review Request 123721: Update virtual functions with Q_DECL_OVERRIDE

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 5aca2afea8e119995c1c3a22e86f84046597e77f by Vishesh Handa on behalf of John Freeman to branch master. Repository: kfilemetadata Description --- Removed virtual and added

Re: Review Request 123721: Update virtual functions with Q_DECL_OVERRIDE

src/extractors/taglibextractor.h 354ded7 Diff: https://git.reviewboard.kde.org/r/123721/diff/ Testing --- make test failed on Test #7 Thanks, John Freeman >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 123712: BasicIndexingJob::typesForMimeType now uses an initializer_list for typeMapper

marked as submitted. Review request for Baloo. Changes --- Submitted with commit af7f76d0b180837fc8e052d8c79176aa79bbb10a by Vishesh Handa on behalf of John Freeman to branch feature/vhanda/lmdb. Repository: baloo Description --- BasicIndexingJob::typesForMimeType no longer checks

Re: Review Request 123712: BasicIndexingJob::typesForMimeType now uses an initializer_list for typeMapper

/basicindexingjob.cpp fc7211a Diff: https://git.reviewboard.kde.org/r/123712/diff/ Testing --- Thanks, John Freeman >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 123712: BasicIndexingJob::typesForMimeType now uses an initializer_list for typeMapper

/basicindexingjob.cpp fc7211a Diff: https://git.reviewboard.kde.org/r/123712/diff/ Testing --- Thanks, John Freeman >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 123712: BasicIndexingJob::typesForMimeType now uses an initializer_list for typeMapper

/basicindexingjob.cpp fc7211a Diff: https://git.reviewboard.kde.org/r/123712/diff/ Testing --- Thanks, John Freeman >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 123712: BasicIndexingJob::typesForMimeType now uses an initializer_list for typeMapper

--- BasicIndexingJob::typesForMimeType no longer checks typeMapper.isEmpty() instead is initialized once with an initializer_list Diffs - src/file/basicindexingjob.cpp fc7211a Diff: https://git.reviewboard.kde.org/r/123712/diff/ Testing --- Thanks, John Freeman >> Visi

Re: Review Request 123695: Update virtual functions with Q_DECL_OVERRIDE/removed 'virtual'

marked as submitted. Review request for Baloo. Changes --- Submitted with commit 9213659a0b4abbc8a9a42124c604b6c3fc39 by Vishesh Handa on behalf of John Freeman to branch feature/vhanda/lmdb. Repository: baloo Description --- Added Q_DECL_OVERRIDE to virtual functions/removed

Re: Review Request 123695: Update virtual functions with Q_DECL_OVERRIDE/removed 'virtual'

ags.h abef372 src/kioslaves/timeline/kio_timeline.h f4fefe7 src/lib/filemonitor.h f4a7640 src/lib/queryrunnable.h c597217 src/lib/taglistjob.h 6dc650d tests/file/fileextractor.h b5c918a Diff: https://git.reviewboard.kde.org/r/123695/diff/ Testing --- Successfully built. Th

Review Request 123695: Update virtual functions with Q_DECL_OVERRIDE

--- Successfully built. Thanks, John Freeman >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Interested in contributing

Ralf, I took a look at the bugs and other parts of the links you sent me, what should I start reading up on next? John > On May 7, 2015, at 7:40 PM, Ralf Habacker wrote: > > Am 08.05.2015 um 02:09 schrieb John Freeman: >> Hi > Hi John, > >> I’m looking for a m

Interested in contributing

Hi I’m looking for a mentor to get started on KDE development I have a reasonable amount of time to do this and experience in c++. Some interesting projects I’ve looked into are Baloo and Kate. Also if you have some suggestions other than those two I am open to that also. I have a background in