Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

2015-12-14 Thread Igor Poboiko
ot; category is checked. Diffs - runners/baloo/baloosearchrunner.cpp 0023a11 Diff: https://git.reviewboard.kde.org/r/125369/diff/ Testing --- It just works: now I am able to find my LaTeX-files, various presentations, etc with KRunner. Thanks, Igor Poboiko >> Visit http:/

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

2015-12-06 Thread Igor Poboiko
combining the two doesn't seem correct. > > > > Maybe others can chime in? > > Igor Poboiko wrote: > Dammit, my fault. Sorry for the noise. I just noticed that sometimes > KRunner don't look for presentations, so I thought the issue was her

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-28 Thread Igor Poboiko
marked as submitted. Review request for Baloo. Changes --- Submitted with commit 22f1ccfb0496c3dabb87acaa815a32f724c3013a by Igor Poboiko to branch master. Repository: baloo Description --- I've noted following bug: sometypes e.g "PDF" (T5) files had a "F

Re: Review Request 125424: Balooctl: Add checkDb command

2015-09-28 Thread Igor Poboiko
> On Сен. 28, 2015, 7:03 д.п., Igor Poboiko wrote: > > Oh, I didn't know that you can feed an ID to balooshow. Yeah, in that case > > I agree with you, URL is not necessary. > > > > Full check now takes some time... It would be useful if it would also > &

Re: Review Request 125424: Balooctl: Add checkDb command

2015-09-28 Thread Igor Poboiko
t;Progress: 30% (elapsed time: 10 min, ETA: 25 min)". But I guess it's needed only in the last check you added, it's the slowest one. Good news: after applying patch from [https://git.reviewboard.kde.org/r/125362/](my review), it does not report any invalid entry :) - Igor Poboiko

Re: Review Request 125424: Balooctl: Add checkDb command

2015-09-27 Thread Igor Poboiko
ype "Document" and type "Folder": # baloosearch --type directory 'result.pdf' /store/documents/[...]/results.pdf # baloosearch --type document 'result.pdf' /store/documents/[...]/results.pdf Reversed c

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

2015-09-25 Thread Igor Poboiko
combining the two doesn't seem correct. > > > > Maybe others can chime in? > > Igor Poboiko wrote: > Dammit, my fault. Sorry for the noise. I just noticed that sometimes > KRunner don't look for presentations, so I thought the issue was her

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

2015-09-25 Thread Igor Poboiko
source codes, but are proper documents): those are mostly LaTeX files or just .txt files with some notes. I expected them to pop up during search. - Igor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-25 Thread Igor Poboiko
stay, but I decided to remove it just to make code clearer (so bugs like that won't pop up later...). - Igor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125362/#review85910 --

Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

2015-09-24 Thread Igor Poboiko
1 Diff: https://git.reviewboard.kde.org/r/125369/diff/ Testing --- It just works: now I am able to find my LaTeX-files, various presentations, etc with KRunner. Thanks, Igor Poboiko >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125351: Don't ignore AND subterm if there is no results

2015-09-24 Thread Igor Poboiko
tch /home/eol/baloo-fix-empty.patch Elapsed: 2.12026 msecs and # baloosearch --type video patch Elapsed: 1.71155 msecs Thanks, Igor Poboiko >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125365: Do not ignore subterms if not found

2015-09-24 Thread Igor Poboiko
> On Сен. 24, 2015, 7:03 д.п., Igor Poboiko wrote: > > Ship It! I've tested it: no more confusing results, it works as expected. Going to close my review request (https://git.reviewboard.kde.org/r/125351/) - Igor

Re: Review Request 125365: Do not ignore subterms if not found

2015-09-24 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125365/#review85854 --- Ship it! Ship It! - Igor Poboiko On Сен. 23, 2015, 6:43

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-23 Thread Igor Poboiko
> changing? > > > > Btw, awesome work at diagnosing this! :) > > Igor Poboiko wrote: > It's not that easy, it takes ~150MB of space. Right now my internet > connection won't accept that X_X > Also I'm not sure you'll be able to reproduce it

Re: Review Request 125362: Avoid QByteArray::fromRawData

2015-09-23 Thread Igor Poboiko
rated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125362/#review85830 ------- On Сен. 23, 2015, 2:42 п.п., Igor Poboiko wrote: > > --- > This is a

Review Request 125362: Avoid QByteArray::fromRawData

2015-09-23 Thread Igor Poboiko
odec.cpp 1edb645 src/engine/documentdatadb.cpp 690df70 src/engine/documentdb.cpp ea0cb66 src/engine/idfilenamedb.cpp d4e1eb1 src/engine/positiondb.cpp 568dc54 src/engine/postingdb.cpp e183db5 Diff: https://git.reviewboard.kde.org/r/125362/diff/ Testing --- After applying this

Re: Review Request 125351: Don't ignore AND subterm if there is no results

2015-09-22 Thread Igor Poboiko
Query&) (which, btw, duplicates the functionality of SearchStore). - Igor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125351/#review85773 --- On

Re: Review Request 125351: Don't ignore AND subterm if there is no results

2015-09-22 Thread Igor Poboiko
# baloosearch --type text patch /home/eol/baloo-fix-empty.patch Elapsed: 2.12026 msecs and # baloosearch --type video patch Elapsed: 1.71155 msecs Thanks, Igor Poboiko >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 125351: Don't ignore AND subterm if there is no results

2015-09-22 Thread Igor Poboiko
arch --type video patch Elapsed: 1.71155 msecs Thanks, Igor Poboiko >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<