Re: Review Request 125359: Remove baloo-monitor from baloo

2015-09-23 Thread Hrvoje Senjan
g/r/125359/#comment59273> Please mention in the changelog that users that will upgrade to KF5 5.15 will lose the app. - Hrvoje Senjan On Sept. 23, 2015, 3:11 p.m., Pinak Ahuja wrote: > > --- > This is an automatically g

Re: Review Request 124919: Re-organize D-Bus interfaces

2015-08-31 Thread Hrvoje Senjan
> On Aug. 31, 2015, 10:45 a.m., Hrvoje Senjan wrote: > > src/dbus/CMakeLists.txt, line 26 > > <https://git.reviewboard.kde.org/r/124919/diff/2/?file=398321#file398321line26> > > > > This looks like a SiC change to me, no? e.g. plasma-desktop won't b

Re: Review Request 124919: Re-organize D-Bus interfaces

2015-08-31 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/124919/#comment58559> This looks like a SiC change to me, no? e.g. plasma-desktop won't build with this commit - Hrvoje Senjan On Aug. 30, 2015, 6:32 p.m., Pinak Ahuja wrote: > > --- > This is an autom

Re: Review Request 119896: Recognize generic KFileMetaData properties in NaturalQueryParser

2014-08-25 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/119896/#comment45596> should be ${BALOO_SOVERSION} instead (other libs are at SOVERSION 1) - Hrvoje Senjan On Aug. 25, 2014, 4:27 p.m., Denis Steckelmacher wrote: > > --- > This is an automatically gener

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Hrvoje Senjan
instead of master - Hrvoje Senjan On Aug. 6, 2014, 6:37 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 118670: Change kfilemetadata's naming scheme to match KF5 libraries

2014-06-12 Thread Hrvoje Senjan
> On June 12, 2014, 7:25 p.m., Aleix Pol Gonzalez wrote: > > In practice, every KF5KFileMetaData should be KF5FileMetaData > > Bernd Steinhauser wrote: > What about the other uses of "KFileMetaData"? > > This definitely goes beyond changing the cmake files (to which I tried to > st