Re: Review Request 120266: Advanced Query Parser: Handle interger and dates

2014-09-18 Thread Denis Steckelmacher
coverage, you can add a test like "fileSize < 2048" so that you check that LessThan is not changed to Equals by the integer value. - Denis Steckelmacher On Sept. 18, 2014, 3:38 p.m., Vishesh Handa wrote: > > --- > Th

Re: Review Request 120163: Implement the Advanced Query Parser using standard lexing and parsing

2014-09-16 Thread Denis Steckelmacher
quivalent to "baloo kde kf5". The > parser therefore keeps the literals separate, as shown in the first example > (there are two terms having no property). > > > Diffs > - > > src/core/advancedqueryparser.cpp 3b222ff > src/core/autotests/advancedqueryparsertest.h 26859a2 > src/core/autotests/advancedqueryparsertest.cpp 14d9cc9 > > Diff: https://git.reviewboard.kde.org/r/120163/diff/ > > > Testing > --- > > The existing tests continue to pass and I've added new ones for AND, OR, > their combination and nested queries. > > > Thanks, > > Denis Steckelmacher > > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 120163: Implement the Advanced Query Parser using standard lexing and parsing

2014-09-16 Thread Denis Steckelmacher
er.cpp 3b222ff src/core/autotests/advancedqueryparsertest.h 26859a2 src/core/autotests/advancedqueryparsertest.cpp 14d9cc9 Diff: https://git.reviewboard.kde.org/r/120163/diff/ Testing --- The existing tests continue to pass and I've added new ones for AND, OR, their combination and nested

Review Request 120163: Implement the Advanced Query Parser using standard lexing and parsing

2014-09-12 Thread Denis Steckelmacher
queryparsertest.cpp 14d9cc9 Diff: https://git.reviewboard.kde.org/r/120163/diff/ Testing --- The existing tests continue to pass and I've added new ones for AND, OR, their combination and nested queries. Thanks, Denis Steckelmacher >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119897: Port the QueryBuilder widget to KF5 and Baloo 5, with auto-completion for file properties

2014-08-25 Thread Denis Steckelmacher
s KDE" and things like that work. File Attachments Code-completion for file properties https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/0ba129e4-56b7-472c-8dac-3b5044bb5a80__baloo-properties-completion.png Thanks, Denis Steckelmacher >> Visi

Re: Review Request 119896: Recognize generic KFileMetaData properties in NaturalQueryParser

2014-08-25 Thread Denis Steckelmacher
unit test has been added for file properties. The Baloo testsuite passes except the "scheduler" test, I don't know if it is normal or a regression (my system has no kded5 nor any KF5 runtime component). Thanks, Denis Steckelmacher >> Visit http://mail.kde.org/mail

Re: Review Request 118448: Use KCalendarSystem to get the list of the month and day names that should be recognized by the query parser

2014-08-22 Thread Denis Steckelmacher
s.cpp 14fa850 Diff: https://git.reviewboard.kde.org/r/118448/diff/ Testing --- The query parser testsuite still passes, and properly gets the name of Gregorian months and days (the tests run using the C locale). Thanks, Denis Steckelmacher >> Visit http://mail.kde.org/mailman/listinf

Re: Review Request 119897: Port the QueryBuilder widget to KF5 and Baloo 5, with auto-completion for file properties

2014-08-22 Thread Denis Steckelmacher
> 400", "artist contains KDE" and things like that work. File Attachments (updated) Code-completion for file properties https://git.reviewboard.kde.org/media/uploaded/files/2014/08/22/0ba129e4-56b7-472c-8dac-3b5044bb5a80__baloo-properties-completi

Review Request 119897: Port the QueryBuilder widget to KF5 and Baloo 5, with auto-completion for file properties

2014-08-22 Thread Denis Steckelmacher
application compiles, launches and works as expected, as does the auto-completion for file properties (screenshot attached). The screenshot does not show it, but "width > 400", "artist contains KDE" and things like that work. Thanks, Denis Steckelmacher >> Visit http://

Review Request 119896: Recognize generic KFileMetaData properties in NaturalQueryParser

2014-08-22 Thread Denis Steckelmacher
eduler" test, I don't know if it is normal or a regression (my system has no kded5 nor any KF5 runtime component). Thanks, Denis Steckelmacher >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 118448: Use KCalendarSystem to get the list of the month and day names that should be recognized by the query parser

2014-08-17 Thread Denis Steckelmacher
arser/pass_periodnames.h 1d7d522 src/queryparser/pass_periodnames.cpp 14fa850 Diff: https://git.reviewboard.kde.org/r/118448/diff/ Testing --- The query parser testsuite still passes, and properly gets the name of Gregorian months and days (the tests run using the C locale). Thanks,

Re: Review Request 119519: QueryParser: Use $ instead of % in the pattern strings

2014-07-28 Thread Denis Steckelmacher
I can send you a "Ship it!", but for me, you have it. - Denis Steckelmacher On July 28, 2014, 2:07 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 118448: Use KCalendarSystem to get the list of the month and day names that should be recognized by the query parser

2014-06-13 Thread Denis Steckelmacher
operly gets the name of Gregorian months and days (the tests run using the C locale). Thanks, Denis Steckelmacher >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 118448: Use KCalendarSystem to get the list of the month and day names that should be recognized by the query parser

2014-06-03 Thread Denis Steckelmacher
> On June 1, 2014, 4:22 p.m., Alexander Potashev wrote: > > What is the user changes the locale at run-time - will the query parser > > reload the month/weekday names? > > Denis Steckelmacher wrote: > It depends on the client application. This list is cached in >

Re: Review Request 118448: Use KCalendarSystem to get the list of the month and day names that should be recognized by the query parser

2014-06-01 Thread Denis Steckelmacher
reply, visit: https://git.reviewboard.kde.org/r/118448/#review58904 --- On June 1, 2014, 11:54 a.m., Denis Steckelmacher wrote: > > --- > This is an automatically generated e-m

Review Request 118448: Use KCalendarSystem to get the list of the month and day names that should be recognized by the query parser

2014-06-01 Thread Denis Steckelmacher
arser testsuite still passes, and properly gets the name of Gregorian months and days (the tests run using the C locale). Thanks, Denis Steckelmacher >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 117085: Add user data in Baloo::Term

2014-03-26 Thread Denis Steckelmacher
sing tests) Thanks, Denis Steckelmacher >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 117085: Add user data in Baloo::Term

2014-03-26 Thread Denis Steckelmacher
/term.h 23df3f1 Diff: https://git.reviewboard.kde.org/r/117085/diff/ Testing --- The code compiles and all the unit tests of Baloo pass ("make test" in the build directory lists 12 passing tests) Thanks, Denis Steckelmacher >> Visit http://mail.kde.org/mailman/listinfo/kd

Re: GSoC proposal : Sharing Metadata Between Multimedia Applications Using Baloo

2014-03-20 Thread Denis Steckelmacher
On 03/20/2014 11:00 AM, Vishesh Handa wrote: Hey Denis I spoke with some other developers regarding what you could do - 1. The "Enhanced Search Dialog" in KMail. I know it's not strictly Baloo work, and it's more UI work than anything else. I've read the entry of the KDE's Idea Page, and it s

Re: GSoC proposal : Sharing Metadata Between Multimedia Applications Using Baloo

2014-03-19 Thread Denis Steckelmacher
On 03/19/2014 05:39 PM, Vishesh Handa wrote: I'm very chary about your proposal. It mostly boils down to the following - 1. More Extractors - The extractors we currently have are decent. We could possibly target some more exif properties, but I'm not sure what else we should be targeting. 2. Fi

GSoC proposal : Sharing Metadata Between Multimedia Applications Using Baloo

2014-03-17 Thread Denis Steckelmacher
e any suggestion and any remark. Denis Steckelmacher Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: GSoC Ideas involving Baloo

2014-03-13 Thread Denis Steckelmacher
On 03/13/2014 03:52 PM, Vishesh Handa wrote: * Support for arbitrary attributes in the file search store (so that we don't need to add explicit support for the hundreds of properties that JPEG and MP3 files can have), if you think that it's a good idea I'm not sure I understand, could you pleas

GSoC Ideas involving Baloo

2014-03-13 Thread Denis Steckelmacher
o use Baloo for multimedia information as extensively as it is currently used for PIM information. Denis Steckelmacher Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Baloo now has a user query parser

2014-03-10 Thread Denis Steckelmacher
On 03/10/2014 08:55 PM, Vishesh Handa wrote: I think that I will have some free time the coming weeks. By the way, would it be possible for me to submit a GSoC proposal for Baloo? Are proposals like "doing these 10 small things" accepted by KDE? I'm also quite interested in KDevelop, but Baloo is

Re: Baloo now has a user query parser

2014-03-10 Thread Denis Steckelmacher
On 03/10/2014 07:54 PM, Vishesh Handa wrote: > I'd love for you to get more involved in Baloo, as you have tons of experience > from Nepomuk. And you're a pretty good coder! Thanks! I would be glad to work on Baloo, the codebase is very clear and easy to understand. The projects involving the

Baloo now has a user query parser

2014-03-09 Thread Denis Steckelmacher
y. I have ported the code, but it is currently #ifdef'ed out. My branch also contains a test suite that is not very extensive but tests all the parsing passes (and allowed me to find plenty of bugs, as the semantics of Term have slightly changed between Nepomuk and Baloo). Denis Steckelmacher Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Parsing user queries in Baloo

2014-03-07 Thread Denis Steckelmacher
On 03/07/2014 05:38 PM, Vishesh Handa wrote: On Saturday, March 01, 2014 10:44:35 AM Denis Steckelmacher wrote: Hi, After having read most of the source code of Baloo and its main clients (the search runner and Dolphin), I'm beginning to see how the whole thing fits. I'm looking fo

Parsing user queries in Baloo

2014-03-01 Thread Denis Steckelmacher
would you integrate the user query parser in Baloo? Denis Steckelmacher Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Reacting to changes in the DOM tree of a web-page displayed in Konqueror

2013-08-28 Thread Denis Steckelmacher
ut no signal is triggered. Is there a mean to get a signal whenever the DOM tree of a document changes ? The best would be that the solution works equally well for web-pages rendered using KHTML or kdewebkit, but if hacks are needed to make one engine or the other work, I would also be happy.

Getting the content of a KParts::SelectorInterface::Element

2013-08-21 Thread Denis Steckelmacher
thods to get the value of attributes. Is there a mean to get the content of a KParts::SelectorInterface::Element (maybe by using another KParts extension or something like that) ? Thanks, Denis Steckelmacher. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<