Re: Falkon in kdereview

2018-02-28 Thread David Rosca
Hi, On Wed, Feb 28, 2018 at 6:24 PM, Jonathan Riddell wrote: > On 28 February 2018 at 11:10, David Rosca wrote: >> Hi, >> I'd like to request review for Falkon. > > Looks good to me. I tidied up licencing and appstream bits. There's > some MPL-1.1 licenc

Re: Mouse settings not use on hot plug of new mouse

2017-08-27 Thread David Rosca
Hi, On Sun, Aug 27, 2017 at 6:58 PM, Kai Uwe Broulik wrote: > Hi, > > I used to experience the same. It's kcminit not properly re-applying settings > as it fails to detect the hotplug event. There's two code paths and one of > them (used on some distros, mostly *buntu?) doesn't properly work i

Re: Review Request 125374: TagListJob: Emit error when failed to open database

2015-09-25 Thread David Rosca
marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 8258e544477ead37aea655eb0b7733f3ecaa93c9 by David Rosca to branch master. Repository: baloo Description --- Emit job result when database can't be opened, so TagListJob::exec()

Review Request 125374: TagListJob: Emit error when failed to open database

2015-09-24 Thread David Rosca
Description --- Emit job result when database can't be opened, so TagListJob::exec() won't hang. Diffs - src/lib/taglistjob.cpp cb9d94e Diff: https://git.reviewboard.kde.org/r/125374/diff/ Testing --- Thanks, David Rosca >> Visit http://mail.kde.org/mailman/li

Review Request 125374: TagListJob: Emit error when failed to open database

2015-09-24 Thread David Rosca
Description --- Emit job result when database can't be opened, so TagListJob::exec() won't hang. Diffs - src/lib/taglistjob.cpp cb9d94e Diff: https://git.reviewboard.kde.org/r/125374/diff/ Testing --- Thanks, David Rosca >> Visit http://mail.kde.org/mailman/li

Re: Review request: QBluez

2015-02-16 Thread David Rosca
> You may want to CC also kde-core-devel and kde-frameworks devel, so it gets > to the right people. Thanks, I sent it now. For anyone who would read it here, I am adding a link to generated documentation: http://david.rosca.cz/qbluez-apidoc/html/ David >> Visit http://mail.kde.org/mailman/list

Review request: QBluez

2015-02-15 Thread David Rosca
ently exposing Manager, Adapter, Device, DevicesModel and PendingCall * possibility to be notified when method call finishes and to be notified about possible errors Currently, there is a qbluez branch in Bluedevil [3]. It will be merged to frameworks branch once QBluez is reviewed. Thanks,