Re: Review Request 125361: Show a nice output if baloo is disabled, rather than "The Baloo Index could not be opened"

2015-09-23 Thread Armin K.
allocations. Otherwise, looks nice. - Armin K. On Sept. 23, 2015, 1:31 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

2015-09-22 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/#review85780 --- Ship it! Ship It! - Armin K. On Sept. 22, 2015, 6:51 p.m

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

2015-09-22 Thread Armin K.
> On Sept. 22, 2015, 6:56 p.m., Armin K. wrote: > > Ship It! It fixes the issue for me too. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/#re

Re: Review Request 124790: Mark all test executables with ecm_mark_as_test()

2015-08-18 Thread Armin K.
marked as submitted. Review request for Baloo. Changes --- Submitted with commit efd024369d00e2c5811cb02ff5c3154c2c67d6c9 by Vishesh Handa on behalf of Armin K to branch master. Repository: baloo Description --- As requested by vhanda, I have marked all test executables with

Re: Review Request 124790: Mark all test executables with ecm_mark_as_test()

2015-08-18 Thread Armin K.
/file/CMakeLists.txt fb58bec Diff: https://git.reviewboard.kde.org/r/124790/diff/ Testing --- I have verified that no files in tests and autotests subdir were built when -DBUILD_TESTING=OFF was passed to cmake. Everything was built when the mentioned build option wasn't used. Thanks

Re: Review Request 124790: Mark all test executables with ecm_mark_as_test()

2015-08-17 Thread Armin K.
/diff/ Testing --- I have verified that no files in tests and autotests subdir were built when -DBUILD_TESTING=OFF was passed to cmake. Everything was built when the mentioned build option wasn't used. Thanks, Armin K. >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 124790: Port to ecm_mark_as_test

2015-08-17 Thread Armin K.
G=OFF was passed to cmake. Everything was built when the mentioned build option wasn't used. Thanks, Armin K. >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 124790: Respect -DBUILD_TESTING=OFF

2015-08-17 Thread Armin K.
built when the mentioned build option wasn't used. Thanks, Armin K. >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 124790: Respect -DBUILD_TESTING=OFF

2015-08-17 Thread Armin K.
24790/diff/ Testing --- I have verified that no files in tests and autotests subdir were built when -DBUILD_TESTING=OFF was passed to cmake. Everything was built when the mentioned build option wasn't used. Thanks, Armin K. >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<