Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-18 Thread Anthony Fieroni
> On Ян. 9, 2017, 9:22 след обяд, Stefan Brüns wrote: > > src/file/extractor/app.cpp, line 165 > > <https://git.reviewboard.kde.org/r/129703/diff/3/?file=488853#file488853line165> > > > > Thats plain wrong, results from multiple extractors are combined! >

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-09 Thread Anthony Fieroni
> On Ян. 9, 2017, 9:22 след обяд, Stefan Brüns wrote: > > src/file/extractor/app.cpp, line 81 > > <https://git.reviewboard.kde.org/r/129703/diff/3/?file=488853#file488853line81> > > > > Bogus constant > > Anthony Fieroni wrote: > I want to be &

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-09 Thread Anthony Fieroni
; > > > > Bogus constant I want to be > 10 - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101909 ----------

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-09 Thread Anthony Fieroni
, but it can cause side effect. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101914 ------- On Ян. 9,

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-08 Thread Anthony Fieroni
issue. Diffs (updated) - src/file/extractor/app.cpp 97332469 src/file/extractor/result.h c800b0dd src/file/extractor/result.cpp 072aebc6 src/tools/balooctl/indexer.cpp 45e42c1c Diff: https://git.reviewboard.kde.org/r/129703/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-03 Thread Anthony Fieroni
the iterators that support a > > given mimetype? > > Anthony Fieroni wrote: > It's a waste of time. Extractor should store file content in DB for fast > access when file content search is performed, so if more than one extractor > performs a file it will result in

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-03 Thread Anthony Fieroni
the iterators that support a > > given mimetype? > > Anthony Fieroni wrote: > It's a waste of time. Extractor should store file content in DB for fast > access when file content search is performed, so if more than one extractor > performs a file it will result in

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-02 Thread Anthony Fieroni
----- On Дек. 27, 2016, 7:34 преди обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129703/ >

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-01 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101694 --- ping - Anthony Fieroni On Дек. 27, 2016, 7:34 преди обяд

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-27 Thread Anthony Fieroni
plaintextextractor. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101591 --- On Дек. 27, 2016, 7:34 пр

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-26 Thread Anthony Fieroni
p.cpp 97332469 src/tools/balooctl/indexer.cpp 45e42c1c Diff: https://git.reviewboard.kde.org/r/129703/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-26 Thread Anthony Fieroni
g Urls as > > paths. I know it's unrelated but maybe you can check? > > Anthony Fieroni wrote: > QByteArray Transaction::documentUrl(quint64 id) const > Url is stored as QByteArray in db, it looks correct. > > Aleix Pol Gonzalez wrote: > It's fine that it

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-25 Thread Anthony Fieroni
mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101575 ----------- On Дек. 25, 2016, 3:27 след обяд, Anthony Fieroni wrote: > > --- > This is an autom

Review Request 129703: [baloo_file_extractor] Limit CPU usage

2016-12-25 Thread Anthony Fieroni
Description --- Processing large directories, +5000 files, can be CPU eater. Large file, itself, can be another issue. Diffs - src/file/extractor/app.cpp 97332469 Diff: https://git.reviewboard.kde.org/r/129703/diff/ Testing --- Thanks, Anthony Fieroni