Bad merge on dolphin.git rolled back

2018-03-01 Thread Nicolás Alvarez
FYI, someone accidentally merged master into stable in dolphin.git: https://phabricator.kde.org/T8127 I rolled back Applications/17.12 to a618383df3. It's now missing: - All the master commits that shouldn't have been there - "Add icons to Edit menu" (D10503) which was probably targeted for master

Re: CI fails to build my last commit in a file I did not change

2018-03-01 Thread Albert Astals Cid
El dijous, 1 de març de 2018, a les 10:25:51 CET, Michael Heidelbach va escriure: > Hi! > > Applications baloo-widgets kf5-qt5 FreeBSDQt5.9/ > kf5-qt5%20FreeBSDQt5.9/> > > What to do now? I think that is because htt

Re: Code in peace or How to lint a complete repository?

2018-03-01 Thread Nicolás Alvarez
El 1 mar. 2018, a la(s) 15:04, Michael Heidelbach escribió: > On 28.02.2018 22:41, Elvis Angelaccio wrote: > This may be right, but it looks weird to me: > > -QMap> positionDb; > +QMap > positionDb; > In C++98 the ">>" is invalid, you need the space in "> >" for correct parsing. In C++

Re: Code in peace or How to lint a complete repository?

2018-03-01 Thread Milian Wolff
On Mittwoch, 28. Februar 2018 10:57:30 CET Michael Heidelbach wrote: > Hi! > > Now that I saw https://phabricator.kde.org/D10905, I want to do > something similar for baloo and baloo-widgets. > > I'd really like to that once and for all. Because applying coding style > on-the-fly obscures real ch

Re: Code in peace or How to lint a complete repository?

2018-03-01 Thread Michael Heidelbach
On 28.02.2018 22:41, Elvis Angelaccio wrote: On mercoledì 28 febbraio 2018 10:57:30 CET, Michael Heidelbach wrote: Hi! Now that I saw https://phabricator.kde.org/D10905, I want to do something similar for baloo and baloo-widgets. I'd really like to that once and for all. Because applying cod

Re: CI fails to build my last commit in a file I did not change

2018-03-01 Thread chinmoy ranjan
The build will restart once there is a new commit. So, apart from pushing a new commit I don't think there is anything you can do right now. On Mar 1, 2018 14:53, "Michael Heidelbach" wrote: Hi! Applications baloo-widgets kf5-qt5 FreeBSDQt5.9/

CI fails to build my last commit in a file I did not change

2018-03-01 Thread Michael Heidelbach
Hi! Applications baloo-widgets kf5-qt5 FreeBSDQt5.9/ What to do now? Cheers, Michael