Re: Falkon in kdereview

2018-02-28 Thread Jonathan Riddell
On Wed, Feb 28, 2018 at 07:51:06PM +0100, Dr.-Ing. Christoph Cullmann wrote: > Hi, > > >> The incubator process seems to have stalled. Christoph can you get > >> this moving again? https://community.kde.org/Incubator/Projects/Falkon > > yes, that has stalled, I didn't update the page to reflect

Re: Code in peace or How to lint a complete repository?

2018-02-28 Thread Elvis Angelaccio
On mercoledì 28 febbraio 2018 10:57:30 CET, Michael Heidelbach wrote: Hi! Now that I saw https://phabricator.kde.org/D10905, I want to do something similar for baloo and baloo-widgets. I'd really like to that once and for all. Because applying coding style on-the-fly obscures real changes in

Re: Code in peace or How to lint a complete repository?

2018-02-28 Thread Michael Heidelbach
On 28.02.2018 20:44, Nicolás Alvarez wrote: 2018-02-28 6:57 GMT-03:00 Michael Heidelbach : Hi! Now that I saw https://phabricator.kde.org/D10905, I want to do something similar for baloo and baloo-widgets. I'd really like to that once and for all. Because applying coding style on-the-fly obscu

Re: Code in peace or How to lint a complete repository?

2018-02-28 Thread Nicolás Alvarez
2018-02-28 6:57 GMT-03:00 Michael Heidelbach : > Hi! > > Now that I saw https://phabricator.kde.org/D10905, I want to do something > similar for baloo and baloo-widgets. > > I'd really like to that once and for all. Because applying coding style > on-the-fly obscures real changes introduced. > > 1.

Re: Falkon in kdereview

2018-02-28 Thread Dr.-Ing. Christoph Cullmann
Hi, >> The incubator process seems to have stalled. Christoph can you get >> this moving again? https://community.kde.org/Incubator/Projects/Falkon yes, that has stalled, I didn't update the page to reflect the current state :/ I did now so. https://community.kde.org/Incubator/Projects/Falkon

Re: Falkon in kdereview

2018-02-28 Thread Jonathan Riddell
On 28 February 2018 at 18:38, David Rosca wrote: > This is just experimental now, and I expect distributions to ignore it > until PySide2 is released. It's optional both at build-time and > run-time (it is built into separate library if enabled). > PySide2 should be released later this year as off

Re: Falkon in kdereview

2018-02-28 Thread David Rosca
Hi, On Wed, Feb 28, 2018 at 6:24 PM, Jonathan Riddell wrote: > On 28 February 2018 at 11:10, David Rosca wrote: >> Hi, >> I'd like to request review for Falkon. > > Looks good to me. I tidied up licencing and appstream bits. There's > some MPL-1.1 licenced files in the themes but I guess that'

Re: Falkon in kdereview

2018-02-28 Thread Jonathan Riddell
On 28 February 2018 at 11:10, David Rosca wrote: > Hi, > I'd like to request review for Falkon. Looks good to me. I tidied up licencing and appstream bits. There's some MPL-1.1 licenced files in the themes but I guess that's fine. I'd query why Python plugins are done with PySide, I'm not sure

Code in peace or How to lint a complete repository?

2018-02-28 Thread Michael Heidelbach
Hi! Now that I saw https://phabricator.kde.org/D10905, I want to do something similar for baloo and baloo-widgets. I'd really like to that once and for all. Because applying coding style on-the-fly obscures real changes introduced. 1. Would it be reasonable? 2. Who would be willing to revie