Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2018-01-25 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129605/ --- (Updated Jan. 25, 2018, 2:04 p.m.) Status -- This change has been di

Re: Is it bad manners to refactor other people's code?

2018-01-25 Thread Martin Flöser
Am 2018-01-25 18:45, schrieb Michael Heidelbach: Hi! Currently I'm working on some code I couldn't understand until I split some long functions into smaller parts. As I couldn't find anything about the size-of-a-function topic in the KDE or Qt guide lines I consider this as a matter of personal

Re: Is it bad manners to refactor other people's code?

2018-01-25 Thread Nicolás Alvarez
El 25 ene. 2018, a la(s) 14:45, Michael Heidelbach escribió: > Hi! > > Currently I'm working on some code I couldn't understand until I split some > long functions into smaller parts. > > As I couldn't find anything about the size-of-a-function topic in the KDE or > Qt guide lines I consider

Is it bad manners to refactor other people's code?

2018-01-25 Thread Michael Heidelbach
Hi! Currently I'm working on some code I couldn't understand until I split some long functions into smaller parts. As I couldn't find anything about the size-of-a-function topic in the KDE or Qt guide lines I consider this as a matter of personal taste. I don't want to step on anybody's toe

Re: Dependent review requests

2018-01-25 Thread Harald Sitter
On Thu, Jan 25, 2018 at 3:00 PM, Michael Heidelbach wrote: > Hi! > > When I do > > git checkout -b A origin/master > > (changes) > > git checkout -b B A > > (changes) > > > git checkout A > > arc diff > > git checkout B > > arc diff > > Will phabricator show the relation of A and B? Is that a reas

Dependent review requests

2018-01-25 Thread Michael Heidelbach
Hi! When I do git checkout -b A origin/master (changes) git checkout -b B A (changes) git checkout A arc diff git checkout B arc diff Will phabricator show the relation of A and B? Is that a reasonable approach, anyway? Michael