kde-devel@kde.org

2017-08-23 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129349/ --- (Updated Aug. 24, 2017, 5:48 a.m.) Review request for Baloo. Changes --

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2017-08-23 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/ --- (Updated Aug. 24, 2017, 7:06 a.m.) Status -- This change has been ma

kde-devel@kde.org

2017-08-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129349/#review103643 --- Btw: would using ::at() instead of operator[] in places impr

kde-devel@kde.org

2017-08-23 Thread Matthieu Gallien
> On août 23, 2017, 7:23 après-midi, Christian Ehrlicher wrote: > > Anyone interested? Otherwise I'll discard this review in the next days I am interested but have no time right now. - Matthieu --- This is an automatically generated e-m

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2017-08-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/#review103641 --- Ship it! Ship It! - Kai Uwe Broulik On Nov. 11, 2016,

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2017-08-23 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/#review103640 --- Anyone interested? Otherwise I'll discard this review in the

kde-devel@kde.org

2017-08-23 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129349/#review103639 --- Anyone interested? Otherwise I'll discard this review in the

Re: Review Request 129650: [baloo] Remove useless includes

2017-08-23 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129650/ --- (Updated Aug. 23, 2017, 7:20 p.m.) Status -- This change has been ma