Re: [kde-devel] Re: kio-stash is in KDE Review

2017-06-28 Thread Arnav Dhamija
Thanks for the suggestions. I've made all these changes in the latest commits. One thing bugging me is that the ID in the AppStream file needs a .desktop file, but I don't have one as this is an application. Should I leave it as it is or create a .desktop file for the same? I'll be uploading the t

Re: [kde-devel] Re: kio-stash is in KDE Review

2017-06-28 Thread Jonathan Riddell
Versioning entirely depends on the project in question. For a library with API/ABI stability it's important to set the right version and update it on API/ABI changes. For anything else it's not too important but it's useful to have one so people can report bugs on a known version, however I'm n

Re: [kde-devel] Re: kio-stash is in KDE Review

2017-06-28 Thread Arnav Dhamija
Is the versioning part on that page still relevant? Many KDE applications I've seen just list the required version of a library as a single decimal separated string (e.g. KF5_MIN_VERSION "5.28.0" rather than splitting it into variables). Also, I have some confusion about AppStream procedure. > Yo

Re: [kde-devel] Re: kio-stash is in KDE Review

2017-06-28 Thread Boudhayan Gupta
Minor nitpicks: 1) Tag names should start with v, such as "v1.2.3" 2) You don't actually have to sign the tarball cryptographically, just give sysadmin a SHA2-256 or better hash out-of-band (i.e., through Phabricator which you access over HTTPS). Freundliche Grüße Boudhayan Gupta KDE e.V. - Sysad

Re: [kde-devel] Re: kio-stash is in KDE Review

2017-06-28 Thread Jonathan Riddell
The page was out of date so I made some updates. Let me know of any unclear or missing information. https://techbase.kde.org/ReleasingExtragearSoftware You need to remove kio-stash from kdereview in repo-metadata, this will mess up the translations. You have i18n() used but no Messages.sh to