Re: New feature for windows bar.

2017-02-05 Thread Karthik Periagaram
Federico, Ideally, you would report suggestions on the bug tracker at https://bugs.kde.org/ or on the KDE forums' brainstorming section at https://forum.kde.org/viewforum.php?f=83 so that any developer who picks it up can track progress or request further information. I'm not sure how actively

New feature for windows bar.

2017-02-05 Thread Federico Acosta
I want to propouse a new feature for kde windows. A button or option in the left menu on windows bar who let anybody change to dark mode or white mode. Whitout matter if eviroment theme is dark or white breeze, for each application. What do you think?

Re: Review Request 129925: fix build of kfilemetadata with taglib version 1.9

2017-02-05 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129925/ --- (Updated Feb. 5, 2017, 7:48 p.m.) Status -- This change has been mar

Re: Review Request 129925: fix build of kfilemetadata with taglib version 1.9

2017-02-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129925/#review102420 --- Ship it! Ship It! - David Faure On Feb. 5, 2017, 4:39

Review Request 129925: fix build of kfilemetadata with taglib version 1.9

2017-02-05 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129925/ --- Review request for Baloo. Repository: kfilemetadata Description ---

Re: Review Request 128664: Nested tags for Baloo

2017-02-05 Thread Boudhayan Gupta
> On Sept. 23, 2016, 2:46 p.m., Boudhayan Gupta wrote: > > Diff looks sane to me, and the feature seems useful in theory. > > > > Will this require a reindexing? Seems to me from previous comments made by > > vHanda that there's a schema change involved? > > James Smith wrote: > Yes. The f

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/ --- (Updated Feb. 5, 2017, 3:30 p.m.) Status -- This change has been mar

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-02-05 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129798/ --- (Updated Feb. 5, 2017, 4:30 p.m.) Status -- This change has been mar

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/#review102415 --- Ship it! Ship It! - David Faure On Feb. 5, 2017, 2:16

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
> On Feb. 5, 2017, 2:09 p.m., David Faure wrote: > > src/properties.h, line 264 > > > > > > Count is supposed to be the count, and Last to be the last. Any reason > > why you're not moving DiscNumber to be befor

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/ --- (Updated Feb. 5, 2017, 3:16 p.m.) Review request for Baloo. Changes ---

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread David Faure
> On Feb. 5, 2017, 1:09 p.m., David Faure wrote: > > src/properties.h, line 264 > > > > > > Count is supposed to be the count, and Last to be the last. Any reason > > why you're not moving DiscNumber to be befor

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
> On Feb. 5, 2017, 2:09 p.m., David Faure wrote: > > src/properties.h, line 264 > > > > > > Count is supposed to be the count, and Last to be the last. Any reason > > why you're not moving DiscNumber to be befor

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/ --- (Updated Feb. 5, 2017, 2:32 p.m.) Review request for Baloo. Changes ---

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/#review102409 --- src/extractors/taglibextractor.cpp (line 111)

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-05 Thread Matthieu Gallien
> On Feb. 4, 2017, 7:59 p.m., Albert Astals Cid wrote: > > Any reason this has not been commited? > > Luigi Toscano wrote: > Because there was no final decision. > > It is true that the Baloo database can be regenerated, but I would say > that if we avoid a complete rebuild of the

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-05 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/ --- (Updated Feb. 5, 2017, 2:02 p.m.) Review request for Baloo and KDE Framew

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-02-05 Thread Matthieu Gallien
> On Feb. 5, 2017, 10:45 a.m., David Faure wrote: > > Patch looks ok to me, although I don't know much about all this. > > > > The real problem isn't tooling, but lack of active maintainership for > > kfilemetadata. Are you interested in taking over? > > Matthieu Gallien wrote: > Hello, >

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-05 Thread Luigi Toscano
> On Feb. 4, 2017, 7:59 p.m., Albert Astals Cid wrote: > > Any reason this has not been commited? > > Luigi Toscano wrote: > Because there was no final decision. > > It is true that the Baloo database can be regenerated, but I would say > that if we avoid a complete rebuild of the

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-02-05 Thread David Faure
> On Feb. 5, 2017, 9:45 a.m., David Faure wrote: > > Patch looks ok to me, although I don't know much about all this. > > > > The real problem isn't tooling, but lack of active maintainership for > > kfilemetadata. Are you interested in taking over? > > Matthieu Gallien wrote: > Hello, >

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-02-05 Thread Matthieu Gallien
> On Feb. 5, 2017, 10:45 a.m., David Faure wrote: > > Patch looks ok to me, although I don't know much about all this. > > > > The real problem isn't tooling, but lack of active maintainership for > > kfilemetadata. Are you interested in taking over? Hello, I have a real interest in kfilemeta

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

2017-02-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129798/#review102399 --- Ship it! Patch looks ok to me, although I don't know much