Re: Review Request 128664: Nested tags for Baloo

2017-02-04 Thread James Smith
> On Sept. 23, 2016, 3:16 a.m., Boudhayan Gupta wrote: > > Diff looks sane to me, and the feature seems useful in theory. > > > > Will this require a reindexing? Seems to me from previous comments made by > > vHanda that there's a schema change involved? > > James Smith wrote: > Yes. The f

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-04 Thread James Smith
> On Feb. 4, 2017, 11:59 a.m., Albert Astals Cid wrote: > > Any reason this has not been commited? > > Luigi Toscano wrote: > Because there was no final decision. > > It is true that the Baloo database can be regenerated, but I would say > that if we avoid a complete rebuild of the

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-04 Thread Luigi Toscano
> On Feb. 4, 2017, 7:59 p.m., Albert Astals Cid wrote: > > Any reason this has not been commited? > > Luigi Toscano wrote: > Because there was no final decision. > > It is true that the Baloo database can be regenerated, but I would say > that if we avoid a complete rebuild of the

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-04 Thread James Smith
> On Feb. 4, 2017, 11:59 a.m., Albert Astals Cid wrote: > > Any reason this has not been commited? > > Luigi Toscano wrote: > Because there was no final decision. > > It is true that the Baloo database can be regenerated, but I would say > that if we avoid a complete rebuild of the

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

2017-02-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/#review102387 --- No need to move this (yet). src/extractors/taglibextractor

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-04 Thread Luigi Toscano
> On Feb. 4, 2017, 7:59 p.m., Albert Astals Cid wrote: > > Any reason this has not been commited? Because there was no final decision. It is true that the Baloo database can be regenerated, but I would say that if we avoid a complete rebuild of the database after a Frameworks update, that wou

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

2017-02-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129605/#review102382 --- Any reason this has not been commited? - Albert Astals Cid

Re: Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

2017-02-04 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127728/ --- (Updated Feb. 4, 2017, 11:09 a.m.) Status -- This change has been di