Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-03 Thread Anthony Fieroni
> On Jan. 3, 2017, 12:51 a.m., Albert Astals Cid wrote: > > Without knowing anything about baloo this looks totally wrong > > > > QList exList = > > m_extractorCollection.fetchExtractors(mimetype); > > > > why would not you want to iterate over all the iterators that support a > > given mim

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-03 Thread Stefan Brüns
> On Jan. 2, 2017, 10:51 p.m., Albert Astals Cid wrote: > > Without knowing anything about baloo this looks totally wrong > > > > QList exList = > > m_extractorCollection.fetchExtractors(mimetype); > > > > why would not you want to iterate over all the iterators that support a > > given mim

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-03 Thread Anthony Fieroni
> On Jan. 3, 2017, 12:51 a.m., Albert Astals Cid wrote: > > Without knowing anything about baloo this looks totally wrong > > > > QList exList = > > m_extractorCollection.fetchExtractors(mimetype); > > > > why would not you want to iterate over all the iterators that support a > > given mim

Re: Review Request 129703: [baloo_file_extractor] Limit CPU usage

2017-01-03 Thread Jan Kundrát
> On Jan. 2, 2017, 10:51 p.m., Albert Astals Cid wrote: > > Without knowing anything about baloo this looks totally wrong > > > > QList exList = > > m_extractorCollection.fetchExtractors(mimetype); > > > > why would not you want to iterate over all the iterators that support a > > given mim