KDE Applications 16.12 getting close

2016-11-06 Thread Albert Astals Cid
Make sure you're aware of these dates November 10, 2016: KDE Applications 16.12 Dependency Freeze November 17, 2016: KDE Applications 16.12 Freeze and Beta (16.11.80) tag & release December 1, 2016: KDE Applications 16.12 RC (16.11.90) Tagging and Release December 8, 2016: KDE Applications 16.1

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-06 Thread David Faure
> On Nov. 6, 2016, 7:36 p.m., David Faure wrote: > > src/codecs/coding.cpp, line 177 > > > > > > remove space before auto; make it "const auto" while at it? ignore the const bit, that was nonsense. - David -

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100660 --- Fix it, then Ship it! src/codecs/coding.cpp (line 160) <

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-06 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100652 --- Ship it! Ship It! - Michael Stemle On Nov. 6, 2016, 12

kde-devel@kde.org

2016-11-06 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129349/ --- Review request for Baloo. Repository: baloo Description --- Use th

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-06 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/ --- (Updated Nov. 6, 2016, 12:58 p.m.) Review request for Baloo, KDE Framewor

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100638 --- src/codecs/coding.cpp (line 114)

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-06 Thread David Faure
> On Nov. 6, 2016, 5:40 a.m., Michael Stemle wrote: > > src/codecs/coding.cpp, line 186 > > > > > > PEDANTIC QUESTION: Why do we `resize()` rather than just using > > `QByteArray((values.size() + 1) * 5, '\0')`?

Re: Review Request 129183: [baloo] CLazy fixes: removed unused member var, add Q_OBJECT

2016-11-06 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129183/ --- (Updated Nov. 6, 2016, 10:56 a.m.) Status -- This change has been ma