Re: Review Request 128664: Nested tags for Baloo

2016-09-23 Thread Boudhayan Gupta
> On Sept. 23, 2016, 2:46 p.m., Boudhayan Gupta wrote: > > Diff looks sane to me, and the feature seems useful in theory. > > > > Will this require a reindexing? Seems to me from previous comments made by > > vHanda that there's a schema change involved? > > James Smith wrote: > Yes. The f

Re: Review Request 128664: Nested tags for Baloo

2016-09-23 Thread James Smith
> On Sept. 23, 2016, 3:16 a.m., Boudhayan Gupta wrote: > > Diff looks sane to me, and the feature seems useful in theory. > > > > Will this require a reindexing? Seems to me from previous comments made by > > vHanda that there's a schema change involved? Yes. The full tag is stored in its own

Re: Review Request 128664: Nested tags for Baloo

2016-09-23 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128664/#review99481 --- Diff looks sane to me, and the feature seems useful in theory