Re-enable new_delete_type_mismatch in ASAN?

2016-08-03 Thread Albert Astals Cid
We disabled the new_delete_type_mismatch ASAN check a while ago because Qt was at fault and creating "false positives" in our code. Since then the Qt code has been fixed (i think), so should we re-enable the check? Cheers, Albert

Re: Review Request 128554: Check for xattr during config step, otherwise the build might fail (if xattr.h is missing). Missing xattr should now trigger an error message to prompt the user into install

2016-08-03 Thread Johan Ouwerkerk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128554/ --- (Updated Aug. 3, 2016, 9:03 p.m.) Status -- This change has been mar

Re: Review Request 128554: Check for xattr during config step, otherwise the build might fail (if xattr.h is missing). Missing xattr should now trigger an error message to prompt the user into install

2016-08-03 Thread Johan Ouwerkerk
> On Aug. 2, 2016, 1:03 p.m., Vishesh Handa wrote: > > Ship It! > > Johan Ouwerkerk wrote: > Should I push to master, or to another branch? Nevermind, there's only the one branch. :) - Johan --- This is an automatically generated e