Review Request 128189: DocumentUrlDB::del Only assert when children of dir actually exist

2016-06-14 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128189/ --- Review request for Baloo. Repository: baloo Description --- We can

Re: Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

2016-06-14 Thread Pinak Ahuja
> On June 14, 2016, 7:04 p.m., David Faure wrote: > > autotests/unit/lib/advancedqueryparsertest.cpp, line 197 > > > > > > You could actually use QTest::ignoreMessage() here, to silence the > > qDebug and ensure

Re: Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

2016-06-14 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128183/ --- (Updated June 14, 2016, 8:23 p.m.) Status -- This change has been ma

Re: Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

2016-06-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128183/#review96498 --- Fix it, then Ship it! Looks good (at this point it's just

Re: Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

2016-06-14 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128183/ --- (Updated June 14, 2016, 6:54 p.m.) Review request for Baloo and David Fau

Survey: Relevance of Configuration Systems in Free and Open Source Software

2016-06-14 Thread Gabriel Rauter
Dear developers, contributors and caretakers of free and open source software. If you are involved in the development of free and open source software (FLOSS) you are the person we are looking for. It would be a great help if you take this survey: http://elektra.limequery.org/625192 It will be a

Re: Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

2016-06-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128183/#review96470 --- This looks very much like something that can be unittested. I

Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

2016-06-14 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128183/ --- Review request for Baloo and David Faure. Repository: baloo Description

Re: Review Request 128176: Remove ifdef'd code needed for Qt version < 5.4.0

2016-06-14 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128176/ --- (Updated June 14, 2016, 10:41 a.m.) Status -- This change has been m