Re: [PATCH 1/2] Fix URL parsing

2016-05-28 Thread Arno
Hi Thiago, On 5/28/2016 3:01 PM, Thiago Macieira wrote: > Em sábado, 28 de maio de 2016, às 01:08:24 BRT, Arno Moeller escreveu: >> As it seems, QUrl does not know about rdp://, so url.scheme() is empty. >> The old code tried to "fix" it by replacing the scheme with vnc://, >> because, as the comm

Re: [PATCH 0/2] KRDC: Fix command line argument handling

2016-05-28 Thread Luigi Toscano
Arno ha scritto: > Hi Burkhard, > > On 5/28/2016 9:06 AM, Burkhard Lück wrote: >> please upload your patch to https://git.reviewboard.kde.org and select the >> repositoriy krdc > > Thanks for the hint. Done: > https://git.reviewboard.kde.org/r/128032/ > I would also add the kdeutils group to th

Re: [PATCH 1/2] Fix URL parsing

2016-05-28 Thread Thiago Macieira
Em sábado, 28 de maio de 2016, às 01:08:24 BRT, Arno Moeller escreveu: > As it seems, QUrl does not know about rdp://, so url.scheme() is empty. > The old code tried to "fix" it by replacing the scheme with vnc://, > because, as the comment stated, it was default in kde3. That doesn't make sense.

Re: [PATCH 0/2] KRDC: Fix command line argument handling

2016-05-28 Thread Arno
Hi Burkhard, On 5/28/2016 9:06 AM, Burkhard Lück wrote: > please upload your patch to https://git.reviewboard.kde.org and select the > repositoriy krdc Thanks for the hint. Done: https://git.reviewboard.kde.org/r/128032/ -- Regards, Arno

Re: [PATCH 0/2] KRDC: Fix command line argument handling

2016-05-28 Thread Burkhard Lück
Am Samstag, 28. Mai 2016, 01:35:18 CEST schrieb Arno: > Hi, > > It just occurred to me that I didn't include a reproducer/test case: > Just try: > ~~ > krdc rdp:// > ~~ > with and without the patches. > The patches are for git://anongit.kde.org/krdc, btw. Hi Anrno, please upload your patch to ht