Re: [PATCH 0/2] KRDC: Fix command line argument handling

Hi, It just occurred to me that I didn't include a reproducer/test case: Just try: ~~ krdc rdp:// ~~ with and without the patches. The patches are for git://anongit.kde.org/krdc, btw. -- Regards, Arno.

[PATCH 2/2] Fix saving host preferences

From: Arno Well, this one was fun. Took me a while to figure out that saving the preferences for a host also destroys the view... When passing an URL via command line, somehow saveHostPrefs() is being called, destroying the just created view, leaving the baffled user with only a new connection v

[PATCH 1/2] Fix URL parsing

From: Arno As it seems, QUrl does not know about rdp://, so url.scheme() is empty. The old code tried to "fix" it by replacing the scheme with vnc://, because, as the comment stated, it was default in kde3. Fix the "fix" by explicitly looking for supported schemes (vnc://, rdp:// and nx://, are

[PATCH 0/2] KRDC: Fix command line argument handling

From: Arno Two small fixes for KRDC. The first patch fixes parsing Url parsing from the command line. When passing rdp://, url.scheme() is empty, so krdc tried to "fix" it by replacing the scheme with vnc:// Once I had that working, I found out that the newly created view was immediately destro

Re: Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127728/#review95908 --- Ship it! Ship It! - Vishesh Handa On April 23, 2016, 4: