Re: New location for Git commit template?

2016-04-23 Thread Michael Pyne
On Sat, April 23, 2016 15:17:24 John Layt wrote: > On 22 April 2016 at 13:15, Thomas Pfeiffer wrote: > > So, where should we put one now? Or is there already one someplace else? > > I'd probably vote for KF5::KCoreAddons as it's the closest thing we > have to kdelibs. The reason it was in kdelibs

Re: Review Request 127726: Fix EXPORT usage.

2016-04-23 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127726/#review94792 --- Ship it! Ship It! - Kevin Funk On April 23, 2016, 4:44

Review Request 127728: Headers generated BalooDBusInterfaces custom target are used in KF5Baloo target sources (IndexerConfig::refresh()), so build this target unconditionally.

2016-04-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127728/ --- Review request for Baloo and kdewin. Repository: baloo Description

Review Request 127727: There is no QT_LSTAT on Windows, use QT_STAT and follow symlink (if needed), only on Windows, instead.

2016-04-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127727/ --- Review request for Baloo and kdewin. Repository: baloo Description

Review Request 127726: Fix EXPORT usage.

2016-04-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127726/ --- Review request for Baloo and kdewin. Repository: baloo Description

Re: New location for Git commit template?

2016-04-23 Thread Thomas Pfeiffer
On Samstag, 23. April 2016 15:17:24 CEST John Layt wrote: > On 22 April 2016 at 13:15, Thomas Pfeiffer wrote: > > So, where should we put one now? Or is there already one someplace else? > > I'd probably vote for KF5::KCoreAddons as it's the closest thing we > have to kdelibs. The reason it was i

Re: New location for Git commit template?

2016-04-23 Thread John Layt
On 22 April 2016 at 13:15, Thomas Pfeiffer wrote: > So, where should we put one now? Or is there already one someplace else? I'd probably vote for KF5::KCoreAddons as it's the closest thing we have to kdelibs. The reason it was in kdelibs rather than just on the wiki was so that when it was chan

Re: New location for Git commit template?

2016-04-23 Thread Olivier Churlaud
Le 22/04/2016 14:15, Thomas Pfeiffer a écrit : Hi everyone, I'm currently going through our documentation for developers, and I've found that the "Commit template" section of the wiki page about Git configuration [1] tells the reader "It is recommended to use the kdelibs template as your default

Re: New location for Git commit template?

2016-04-23 Thread Elvis Angelaccio
2016-04-22 14:15 GMT+02:00 Thomas Pfeiffer : > Hi everyone, > I'm currently going through our documentation for developers, and I've > found > that the "Commit template" section of the wiki page about Git > configuration [1] > tells the reader "It is recommended to use the kdelibs template as your