Re: Projects using the plasma-framework for inspiration

2015-11-24 Thread Olivier Churlaud
Le 24/11/2015 19:11, Marco Martin a écrit : On Monday 23 November 2015, Olivier Churlaud wrote: Le 23/11/2015 17:18, Olivier Churlaud a écrit : Le 23/11/2015 16:15, Marco Martin a écrit : I suggest you to take a look at the file "standaloneappcorona.cpp" in plasma- framework I just cloned pla

Re: Projects using the plasma-framework for inspiration

2015-11-24 Thread Marco Martin
On Monday 23 November 2015, Olivier Churlaud wrote: > Le 23/11/2015 17:18, Olivier Churlaud a écrit : > > Le 23/11/2015 16:15, Marco Martin a écrit : > >> I suggest you to take a look at the file "standaloneappcorona.cpp" in > >> plasma- > >> framework > > > > I just cloned plasma-framework but di

Re: Review Request 126132: Better bitrate format in filemetadatawidget

2015-11-24 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126132/ --- (Updated Nov. 24, 2015, 5:12 p.m.) Status -- This change has been ma

Re: Review Request 126110: Clean up and armour Baloo::Database::open()

2015-11-24 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126110/ --- (Updated Nov. 24, 2015, 11:42 a.m.) Status -- This change has been m

Re: Review Request 126110: Clean up and armour Baloo::Database::open()

2015-11-24 Thread Boudhayan Gupta
> On Nov. 24, 2015, 4:20 p.m., Vishesh Handa wrote: > > src/engine/database.cpp, line 73 > > > > > > Please remove the comment. It's not longer valid. We still are checking if the index exists and bailing out ear

Re: Review Request 126006: KF5 compilation failing due to baloo tests/file/CMakeLists.txt

2015-11-24 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126006/#review88753 --- Ping? - Vishesh Handa On Nov. 9, 2015, 3:51 p.m., Jan Issac

Re: Review Request 126132: Better bitrate format in filemetadatawidget

2015-11-24 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126132/#review88752 --- Ship it! src/widgetfactory.cpp (line 118)

Re: Review Request 126110: Clean up and armour Baloo::Database::open()

2015-11-24 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126110/#review88751 --- Ship it! src/engine/database.cpp (line 73)