Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

2015-10-24 Thread Pinak Ahuja
> On Oct. 24, 2015, 8:16 p.m., Vishesh Handa wrote: > > src/file/unindexedfileindexer.cpp, line 66 > > > > > > This is a silly thing, but do you think perhaps we should move this > > 'renameFilePath' call inside

Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

2015-10-24 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125776/#review87350 --- src/file/unindexedfileindexer.cpp (line 65)

Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

2015-10-24 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125777/#review87348 --- src/qml/experimental/monitor.cpp (line 146)

Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

2015-10-24 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125777/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

2015-10-24 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125776/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-24 Thread Boudhayan Gupta
> On Oct. 24, 2015, 6 p.m., Vishesh Handa wrote: > > I still have many thoughts regarding this particular approach, and third > > party plugins in general. I'm trying to write them into a cohesive blob. Do you mean the entire current extractor interface, or just this patch? What do you mean, "

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-24 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review87334 --- I still have many thoughts regarding this particular approach,

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-10-24 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- (Updated Oct. 24, 2015, 5:49 p.m.) Review request for Baloo, KDE Framewor