Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Boudhayan Gupta
> On Oct. 10, 2015, 12:58 a.m., Boudhayan Gupta wrote: > > src/lib/searchstore.cpp, line 126 > > > > > > Shouldn't this be qMin(size, offset + limit)? > > Vishesh Handa wrote: > I don't think it matters. >

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Vishesh Handa
> On Oct. 9, 2015, 7:28 p.m., Boudhayan Gupta wrote: > > src/lib/searchstore.cpp, line 126 > > > > > > Shouldn't this be qMin(size, offset + limit)? I don't think it matters. If there aren't any more elements t

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86568 --- src/lib/searchstore.cpp (line 122)

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/ --- (Updated Oct. 9, 2015, 6:57 p.m.) Status -- This change has been mar

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86564 --- Ship it! Awesome work. Thanks a lot for taking care of this.

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/ --- (Updated Oct. 9, 2015, 5:54 p.m.) Review request for Baloo, Release Team

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/ --- (Updated Oct. 9, 2015, 5:47 p.m.) Review request for Baloo, Release Team

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Xuetian Weng
> On Oct. 9, 2015, 11:21 a.m., Vishesh Handa wrote: > > src/lib/searchstore.cpp, line 103 > > > > > > Say we have 50 results > > > > limit = 10 > > offset = 5 > > > > So we want results from

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Xuetian Weng
> On Oct. 9, 2015, 11:21 a.m., Vishesh Handa wrote: > > src/lib/searchstore.cpp, line 103 > > > > > > Say we have 50 results > > > > limit = 10 > > offset = 5 > > > > So we want results from

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Xuetian Weng
> On Oct. 9, 2015, 11:21 a.m., Vishesh Handa wrote: > > src/lib/searchstore.cpp, line 114 > > > > > > The entire code in this else case is absolutely rubbish. The person > > implementing it should feel bad (me).

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Xuetian Weng
> On Oct. 9, 2015, 11:49 a.m., Emmanuel Pescosta wrote: > > Should fix bug 348902 :) I don't think it's the same bug. The bug that I tries to fixed here is introduced between 5.14 - 5.15. - Xuetian --- This is an automatically generate

Krfb

2015-10-09 Thread Jeremy Whiting
Hello all, I've ported Krfb to kf5/qt5 on the frameworks branch. It seems to work well here, but I am not the maintainer so thought it would be good if others can take a look at the code also. If one or two people would give it a try I would appreciate it. I'd like to merge frameworks branch to ma

Re: sound - definitively no sound

2015-10-09 Thread Luca Beltrame
Il Fri, 09 Oct 2015 14:21:40 +0200, Stéphane ancelot ha scritto: Hello, > Howto inhibit audio system in kde ? This mailing list is to discuss issues related to the development of KDE software. Your mail is a question on the software itself, and as such may be better suited for the KDE Communit

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86551 --- Can someone check if this also fixes display in the timeline:/

sound - definitively no sound

2015-10-09 Thread Stéphane ancelot
Hi, I have definitively no sound audio interface in my machine. Howto inhibit audio system in kde ? Regards S.Ancelot Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86541 --- Should fix bug 348902 :) - Emmanuel Pescosta On Oct. 9, 201

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

2015-10-09 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86535 --- I'm adding the release team since maybe we can delay the relea

Re: problem stacking panels.

2015-10-09 Thread Thomas Lübking
On Freitag, 9. Oktober 2015 08:29:14 CEST, Stéphane ancelot wrote: Area 3 : this is an area dedicated to our application with some buttons to drive a CNC machine. That part must be re-ingenered to be integrated in KDE environment. (I don't know at this time which kde technology it should use ?