Re: Review Request 125496: i18n fixes for balooctl config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125496/#review86265 --- Ship it! - Vishesh Handa On Oct. 2, 2015, 9:29 p.m., Luigi

Re: Review Request 125496: i18n fixes for balooctl config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125496/#review86258 --- Ship it! - Aleix Pol Gonzalez On Oct. 2, 2015, 11:29 p.m.,

Re: Review Request 125496: i18n fixes for balooctl config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125496/#review86254 --- On the other side, if the tagging is tomorrow, this review (if

Review Request 125496: i18n fixes for balooctl config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125496/ --- Review request for Baloo, Pinak Ahuja and Vishesh Handa. Repository: balo

Re: Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125482/ --- (Updated Oct. 2, 2015, 5:34 p.m.) Status -- This change has been mar

Re: Review Request 125481: Port balooctl check to work with new architecture

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/ --- (Updated Oct. 2, 2015, 5:34 p.m.) Status -- This change has been mar

Re: Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125482/ --- (Updated Oct. 2, 2015, 5:33 p.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

> On Oct. 2, 2015, 3:47 p.m., Vishesh Handa wrote: > > src/tools/balooctl/configcommand.cpp, line 86 > > > > > > whether not weather > > > > Or you could use 'if'. oops :| - Pinak ---

Re: Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125482/#review86245 --- src/tools/balooctl/configcommand.cpp (line 86)

Re: Review Request 125481: Port balooctl check to work with new architecture

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/#review86244 --- Ship it! src/file/unindexedfileiterator.cpp (line 97)

Re: Review Request 125481: Port balooctl check to work with new architecture

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/ --- (Updated Oct. 2, 2015, 2:57 p.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 125481: Port balooctl check to work with new architecture

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/ --- (Updated Oct. 2, 2015, 2:55 p.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 125481: Port balooctl check to work with new architecture

> On Oct. 2, 2015, 1:28 p.m., Vishesh Handa wrote: > > src/file/unindexedfileindexer.cpp, line 59 > > > > > > Are you sure this is the right thing to be doing? I'm imagining the > > case when the filename has cha

Re: Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125482/ --- (Updated Oct. 2, 2015, 2 p.m.) Review request for Baloo and Vishesh Handa

Re: Review Request 125481: Port balooctl check to work with new architecture

> On Oct. 2, 2015, 1:28 p.m., Vishesh Handa wrote: > > src/file/unindexedfileindexer.cpp, line 59 > > > > > > Are you sure this is the right thing to be doing? I'm imagining the > > case when the filename has cha

Re: Review Request 125481: Port balooctl check to work with new architecture

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/#review86228 --- src/file/unindexedfileindexer.cpp (line 59)

Re: Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125482/#review86227 --- Could you please give it a better name such as 'contentIndexin

Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125482/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Review Request 125481: Port balooctl check to work with new architecture

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/ --- Review request for Baloo and Vishesh Handa. Bugs: 353011 http://bugs.