Re: Review Request 125429: Baloo: Fix dbus warnings

2015-09-30 Thread Vishesh Handa
> On Sept. 29, 2015, 2:24 p.m., Pinak Ahuja wrote: > > src/file/filecontentindexer.cpp, line 84 > > > > > > Wouldn't this slot be executed in the main thread? We most probably > > don't need this. I'm confused.

Re: Review Request 125430: FileContentIndexer: Fix threading issues

2015-09-30 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125430/ --- (Updated Sept. 30, 2015, 4:41 p.m.) Status -- This change has been d

Re: Review Request 125429: Baloo: Fix dbus warnings

2015-09-30 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125429/ --- (Updated Sept. 30, 2015, 4:41 p.m.) Status -- This change has been m

Re: Review Request 125424: Balooctl: Add checkDb command

2015-09-30 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125424/ --- (Updated Sept. 30, 2015, 4:41 p.m.) Status -- This change has been m

Re: Review Request 125430: FileContentIndexer: Fix threading issues

2015-09-30 Thread Vishesh Handa
> On Sept. 29, 2015, 3:10 p.m., Pinak Ahuja wrote: > > Oh wait, I don't think this is needed all slots that modify m_monitors run > > in the creation/main thread also m_currentFile is updated in the > > slotIndexingFile and read in the QProperty getter (I should probably make > > it const) bot

Re: Review Request 125424: Balooctl: Add checkDb command

2015-09-30 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125424/#review86164 --- Ship it! Ship It! - Pinak Ahuja On Sept. 27, 2015, 11:51 p