Re: plasma-nm fails to build

2015-09-29 Thread Jeffrey Brusseau
Thanks guys. I wonder why I didn't get errors for missing header files or something for qca. I guess this is the kind of thing Cmake would normally be made to check for and throw an error over. On Sep 29, 2015 4:45 AM, "Luca" wrote: > Here a quick patch that let's you build qca from git with kdes

Re: Review Request 125430: FileContentIndexer: Fix threading issues

2015-09-29 Thread Pinak Ahuja
> On Sept. 29, 2015, 2:56 p.m., Pinak Ahuja wrote: > > src/file/filecontentindexer.cpp, line 80 > > > > > > Maybe we can move this below m_filePath = filePath; ? > > > > Wouldn't make a lot of difference

Re: Review Request 125430: FileContentIndexer: Fix threading issues

2015-09-29 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125430/#review86118 --- Oh wait, I don't think this is needed all slots that modify m_

Re: Review Request 125430: FileContentIndexer: Fix threading issues

2015-09-29 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125430/#review86116 --- Ship it! Makes sense, didn't realize multiple monitors can ca

Re: Review Request 125414: balooctl config: Add excludeFilter

2015-09-29 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125414/ --- (Updated Sept. 29, 2015, 2:48 p.m.) Status -- This change has been m

Re: Review Request 125429: Baloo: Fix dbus warnings

2015-09-29 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125429/#review86113 --- Ship it! src/file/filecontentindexer.cpp (line 72)

Re: plasma-nm fails to build

2015-09-29 Thread Luca
Here a quick patch that let's you build qca from git with kdesrc-build enjoy On 29 September 2015 at 08:11, Harald Sitter wrote: > you need to build qca from git as well. > > On Tue, Sep 29, 2015 at 4:06 AM, Jeffrey Brusseau > wrote: > > I'm trying to build KF5 (inside a archlinux base docker

Re: plasma-nm fails to build

2015-09-29 Thread Harald Sitter
you need to build qca from git as well. On Tue, Sep 29, 2015 at 4:06 AM, Jeffrey Brusseau wrote: > I'm trying to build KF5 (inside a archlinux base docker container via this > project). It ran all the way up to plasma-nm, failed to compile then > stopped. Here's the build log: > >> [kdedev@d6701d